┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/places/placespanel.cpp
AgeCommit message (Collapse)Author
2026-02-11panels/panels: handle lifetime of internal actionsMéven Car
Preventing a mem-leak on process leave.
2025-09-26placespanel: Fix default width by moving things from showEvent to constructorTem PQD
Move instantiation, setModel, and some connections to constructor and remove showEvent. This was being done in an erroneous lazy order which led to the places panel's sizeHint not being called properly. Also removes the double loading workaround in setUrl, which is no longer needed either. BUG: 449070
2025-03-04Use nicer split iconNate Graham
This is the icon that Konsole uses, and it communicates the point better than the current one. Related to #68
2025-03-03placespanel: Use correct loop index when connecting device signalsWang Yu
The loop in slotRowsInserted was using the 'first' parameter instead of the loop variable 'i', causing only the first index to be connected multiple times.
2024-07-01Revert "DragAndDropHelper::updateDropAction: use StatJob for remote URLs"Felix Ernst
This reverts commit dc149ec5e52f52c514cf362603d05ba8eea506b8. This prevents a crash. One issue identified is that the commit that I am reverting here accesses a QDropEvent at a moment in time in which it might have already been deleted. We cannot check if it exists by that time because we do not control its lifetime and it is not a QObject.
2024-02-29DragAndDropHelper::updateDropAction: use StatJob for remote URLsJin Liu
When dragging onto tabs/Places from a remote URL, we don't process the QDropEvent immediately, but start a StatJob and process the event when it finishes. Also, the result of the StatJob is cached for 30 seconds, to avoid starting duplicate jobs.
2024-02-17Improve DnD handling in read-only dirsJin Liu
1. Places panel and tabbar update drag status in read-only dir 2. Don't create drop job in readonly directories
2023-11-26Places Panel: Swap "Open in Split View" and "Configure Trash"Kai Uwe Broulik
Ensure the "open" actions are all in a row.
2023-09-10Merge remote-tracking branch 'origin/master' into kf6Méven Car
2023-09-09Add open in split view actionEric Armbruster
This action is shown only if a single folder is selected. The action opens the selected folder in the inactive split view (and opens the split view if necessary). FEATURE: 465500
2023-07-05Merge branch 'master' into kf6Nicolas Fella
2023-07-05Add explicit moc includes to sources for moc-covered headersFriedrich W. H. Kossebau
* speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods
2023-05-08Merge branch 'master' into kf6Méven Car
2023-05-07Port to Qt6Méven Car
2023-04-03PlacesPanel: clean some warningsMéven Car
NO_CHANGELOG
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2022-11-29Places Panel: Delegate open file error to KIOKai Uwe Broulik
This functionality is now provided by `KFilePlacesModel` as long as you tell it to do the teardown rather than calling into the device yourself.
2022-09-26Remove unused includesLaurent Montel
2022-08-24Don't show error message on ERR_USER_CANCELEDKai Uwe Broulik
There's no point telling the user what they just did. After https://invent.kde.org/frameworks/kio/-/commit/f192c133eb01bc8448d5ddd97fe20f8e6dbc467d this error has a text associated with it, so it might show up in the UI.
2022-08-22Places Panel: Don't show error message on UserCanceledKai Uwe Broulik
There's no point telling the user what they just did
2022-03-04[Places Panel] Reject drops on unwritable locationsKai Uwe Broulik
Indicate that you cannot drop here. Avoids a "Cannot drop file" or "not supported" error when dropping files ontop of a search or timeline URL. It is done in Dolphin rather than the library as there we cannot assume what a consumer might be doing with the drop.
2022-02-07[Places Panel] Make use of KFilePlacesView::dragAutoActivationDelayKai Uwe Broulik
Code moved to KIO
2022-01-24[Places Panel] Stop drag activation timer when droppingKai Uwe Broulik
Avoids switching folders after a drop while interacting with the Copy/Move/Link menu.
2022-01-09Port back to KFilePlacesViewKai Uwe Broulik
This removes the custom-view engine version of the places panel and replaces it with the upstream `KFilePlacesView` from KIO.
2021-12-28kitemlistview: Port KItemListView::itemAt to std::optionalFushan Wen
Use `value_or(-1)` for those functions that don't use `std::optional`.
2021-12-17Enable Ctrl/Shift-Click to open folder in a new tab/windowAlessio Bonfiglio
and more
2021-11-02Remove duplicate include from .h/.cppLaurent Montel
2021-05-20Add action to places panel context menu trash entry to open trash settingsSaravanan K
BUG: 367583 FIXED-IN: 21.08
2021-02-09Add missing includesNicolas Fella
2020-11-23Places panel: highlight place only when it is displayedMéven Car
BUG: 156678 FIXED-IN: 20.12
2020-11-16PlacesPanel: tooltip, use toLocalFile instead of pathMéven Car
To avoid Windows compatiblity issues.
2020-11-10Places panel: show a tooltip after 500 msMéven Car
BUG: 426455 FIXED-IN: 20.12
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-10-23Compile without foreachAlexander Lohnau
2020-10-23Show home folder if needed after unmounting mounted diskNate Graham
Right now, when you unmount a device that any active view containers are displaying, nothing in the view changes. As a result, it's possible to try to navigate to files or folders in that view, which cannot be done because the disk that the files or folders are located on has been unmounted! With this commit, we detect that case and switch the view containers to show the home folder after the disk whose contents they are displaying gets unmounted. BUG: 158934 FIXED-IN: 20.12
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-02-12Swap "Open in New Window" and "Open in New Tab" in context menusIlya Bizyaev
Summary: Since Dolphin's default behaviour became opening in new tabs rather than in new windows (a very positive change, in my opinion), I always find myself accidentally opening folders in new windows from the context menu. This is because in most browsers with tab workflow (e.g. Firefox, Chromium, Falkon) the top context menu action is opening in a new tab, and my muscle memory plays a bad trick :) I'm aware of middle-clicking, but I find it inconvenient with my touchpad. I suspect I'm probably not alone in that, so I think it makes sense to swap these actions in Dolphin to match widely used apps. Test Plan: Open Dolphin, right click folders in the main view and in the Places panel, ensure the actions are indeed swapped Reviewers: #vdg, ndavis, #dolphin, ngraham Reviewed By: #vdg, ndavis, #dolphin, ngraham Subscribers: ngraham, ndavis, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D27318
2019-11-19Port deprecated methodsLaurent Montel
2019-09-08GIT_SILENT: minor qstring optimizationLaurent Montel
2019-09-04Use better-named visible and hidden iconsNate Graham
2019-06-04Merge branch 'Applications/19.04'Kai Uwe Broulik
2019-06-04[Places Panel] Pass iconName to KFilePlaceEditDialogKai Uwe Broulik
Ensures that editing an entry with a custom icon doesn't have its icon discarded. Differential Revision: https://phabricator.kde.org/D21558
2019-05-12Fix indentationElvis Angelaccio
GIT_SILENT
2019-03-24Move Safely Remove down in places context menuTigran Gabrielyan
Summary: BUG: 405620 Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19950
2019-02-27remove deprecated methodsLaurent Montel
2018-12-02[PlacesPanel] Fix unused variable warningElvis Angelaccio
2018-11-24[PlacesPanel] Port to KFilePlaceEditDialogElvis Angelaccio
Summary: This patch ports away from the old PlacesItemEditDialog copy, which doesn't honour the "applicationLocal" checkbox. KFilePlaceEditDialog was not exported by KIO, but it will be starting from 5.53 BUG: 376619 FIXED-IN: 19.03.80 Test Plan: * Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox * Edit an existing (global) place and check the "only show in dolphin" checkbox Reviewers: #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16824
2018-11-17Improve Ux for the places panel's hidden itemsChris Rizzitello
Summary: BUG: 400860 FIXED-IN: 18.12.0 Clean up the context menu for the places panel. - Change Text "Show All Entries" -> "Show Hidden Places" - Use State dependent icon (like hidden files) - Disable instead of hide if not places are hidden. - Toggle to unchecked if last item of group is unhidden. Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places. Test Plan: With Hidden Places {F6398756} {F6398759} Context Menu: {F6398762} {F6398761} Without Hidden Places. {F6414694} {F6414696} Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel Tags: #dolphin Maniphest Tasks: T8349 Differential Revision: https://phabricator.kde.org/D16767
2018-10-14Add a 'Properties' entry in the Places panel context menuThomas Surrel
Summary: BUG: 181880 Test Plan: Right-click on a place or on a device in the Places panel now show a Properties entry. Clicking on it will open its folder property. Reviewers: #dolphin, #plasma, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, cfeck, ngraham, abetts, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15929
2018-10-11Disable unmount option for / or /homeThomas Surrel
Summary: This removes the 'Unmount' context menu in the Places panel for discs corresponding to / and /home. It does not make much sense to offer an option that will always fail. BUG: 399659 Reviewers: #dolphin, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: sefaeyeoglu, elvisangelaccio, ngraham, broulik, bruns, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15989
generated by cgit v1.3 (git 2.53.0) at 2026-04-18 05:54:26 +0000