| Age | Commit message (Collapse) | Author |
|---|
|
Preventing a mem-leak on process leave.
|
|
Move instantiation, setModel, and some connections to constructor and remove showEvent.
This was being done in an erroneous lazy order which led to the places panel's sizeHint not being called properly.
Also removes the double loading workaround in setUrl, which is no longer needed either.
BUG: 449070
|
|
This is the icon that Konsole uses, and it communicates the point better
than the current one.
Related to #68
|
|
The loop in slotRowsInserted was using the 'first' parameter instead
of the loop variable 'i', causing only the first index to be connected
multiple times.
|
|
This reverts commit dc149ec5e52f52c514cf362603d05ba8eea506b8.
This prevents a crash. One issue identified is that the commit that
I am reverting here accesses a QDropEvent at a moment in time in
which it might have already been deleted. We cannot check if it
exists by that time because we do not control its lifetime and it
is not a QObject.
|
|
When dragging onto tabs/Places from a remote URL, we don't process
the QDropEvent immediately, but start a StatJob and process the
event when it finishes.
Also, the result of the StatJob is cached for 30 seconds, to avoid
starting duplicate jobs.
|
|
1. Places panel and tabbar update drag status in read-only dir
2. Don't create drop job in readonly directories
|
|
Ensure the "open" actions are all in a row.
|
|
|
|
This action is shown only if a single folder is selected. The action
opens the selected folder in the inactive split view (and opens the
split view if necessary).
FEATURE: 465500
|
|
|
|
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
|
|
|
|
|
|
NO_CHANGELOG
|
|
|
|
This functionality is now provided by `KFilePlacesModel` as long as
you tell it to do the teardown rather than calling into the device yourself.
|
|
|
|
There's no point telling the user what they just did.
After https://invent.kde.org/frameworks/kio/-/commit/f192c133eb01bc8448d5ddd97fe20f8e6dbc467d
this error has a text associated with it, so it might
show up in the UI.
|
|
There's no point telling the user what they just did
|
|
Indicate that you cannot drop here.
Avoids a "Cannot drop file" or "not supported" error when
dropping files ontop of a search or timeline URL.
It is done in Dolphin rather than the library as there we cannot
assume what a consumer might be doing with the drop.
|
|
Code moved to KIO
|
|
Avoids switching folders after a drop while interacting with
the Copy/Move/Link menu.
|
|
This removes the custom-view engine version of the places panel
and replaces it with the upstream `KFilePlacesView` from KIO.
|
|
Use `value_or(-1)` for those functions that don't use `std::optional`.
|
|
and more
|
|
|
|
|
|
This MR removes the horizontal scrollbar of the Places panel. For titles that don't fit in the panel, their elided versions will be used (i.e., with ...).
BUG: 301758
|
|
This reverts commit e9a39700fc004004b1ff231023e9d5333a2b8317.
|
|
This reverts commit 56888a567fc741713b6c905aeed3842a7fa230c7.
|
|
This patch makes the Places panel to use SmallMedium icon size as default, making it easier to read. It also removes extra spacing from items with small icons (reverts e9a39700 and 56888a56).
BUG: 437345
|
|
BUG: 367583
FIXED-IN: 21.08
|
|
padding was only applied when the icon size was applied, the icon size
however is only applied when the user had set an explicit size. this
resulted in inconsistent spacing. by default no padding would be used if
the user had changed the icon size to medium and back to small it would
suddenly have padding.
to fix this, set padding unconditionally on construction and never touch
it again .
BUG: 435731
|
|
NO_CHANGELOG
|
|
|
|
|
|
BUG: 430441
|
|
|
|
BUG: 156678
FIXED-IN: 20.12
|
|
To avoid Windows compatiblity issues.
|
|
BUG: 426455
FIXED-IN: 20.12
|
|
|
|
Use early returns instead of deeply nested if/else.
|
|
|
|
|
|
|
|
|
|
The draw code is more like the last state of D21312 now.
|
|
Based on this kio filepicker patch:
https://github.com/KDE/kio/commit/933887dc334f3498505af7a86d25db7faae91019
|
