┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/places
AgeCommit message (Collapse)Author
2021-07-24[PlacesPanel] Remove horizontal scrollbarEugene Popov
This MR removes the horizontal scrollbar of the Places panel. For titles that don't fit in the panel, their elided versions will be used (i.e., with ...). BUG: 301758 (cherry picked from commit deaf5916f2f87d78825f33f2ba11475a24c9380f)
2021-05-29Revert "Improve padding in the Places View"Eugene Popov
This reverts commit e9a39700fc004004b1ff231023e9d5333a2b8317.
2021-05-29Revert "fix padding in places view"Eugene Popov
This reverts commit 56888a567fc741713b6c905aeed3842a7fa230c7.
2021-05-29Use SmallMedium icon size in the Places panel as defaultEugene Popov
This patch makes the Places panel to use SmallMedium icon size as default, making it easier to read. It also removes extra spacing from items with small icons (reverts e9a39700 and 56888a56). BUG: 437345
2021-05-20Add action to places panel context menu trash entry to open trash settingsSaravanan K
BUG: 367583 FIXED-IN: 21.08
2021-04-19fix padding in places viewHarald Sitter
padding was only applied when the icon size was applied, the icon size however is only applied when the user had set an explicit size. this resulted in inconsistent spacing. by default no padding would be used if the user had changed the icon size to medium and back to small it would suddenly have padding. to fix this, set padding unconditionally on construction and never touch it again . BUG: 435731
2021-02-14Remove a missing emit KEYWORDMéven Car
NO_CHANGELOG
2021-02-09Build with QT_NO_KEYWORDSNicolas Fella
2021-02-09Add missing includesNicolas Fella
2020-12-17Fix crash when device with capacitybar is draggedChris Holland
BUG: 430441
2020-12-15Fix KIO warning when URL is emptyDavid Faure
2020-11-23Places panel: highlight place only when it is displayedMéven Car
BUG: 156678 FIXED-IN: 20.12
2020-11-16PlacesPanel: tooltip, use toLocalFile instead of pathMéven Car
To avoid Windows compatiblity issues.
2020-11-10Places panel: show a tooltip after 500 msMéven Car
BUG: 426455 FIXED-IN: 20.12
2020-11-09PlacesItemListWidget: Use Solid to check if device is a network shareMéven Car
2020-11-04Use QDeadlineTimer instead of QDateTime.Chris Holland
Use early returns instead of deeply nested if/else.
2020-11-04Cleanup importsChris Holland
2020-11-04Remove wip debuggingChris Holland
2020-11-04Fix freeSpaceInfo cache not being reset.Chris Holland
2020-11-04Use KDE GitLab url instead of the GitHub mirrorChris Holland
2020-11-04Cleanup unused colors. Use const. Use KColorScheme danger.Chris Holland
The draw code is more like the last state of D21312 now.
2020-11-04Refactor capacity by to use async KIO FreeSpaceJob.Chris Holland
Based on this kio filepicker patch: https://github.com/KDE/kio/commit/933887dc334f3498505af7a86d25db7faae91019
2020-11-04Only show capacity bar for devices (has a udi).Chris Holland
2020-11-04Only check if place url is mount point once during polish event.Chris Holland
The capacity bars will no longer update when capacity changes. It only checks the size on init. Updating during polish event is only a temporarily solution just to draft code flow for seperating logic from painting. Eventually this logic update should be in a worker thread detached from blocking the rendering thread that blocks launching the dolphin window.
2020-11-04Draw 2 Rectangles below mount points to represent a disk capacity barChris Holland
Draws overtop text that's goes below the baseline like a 'j'. It's fairly difficult to add extra space below the text as the places view is a "details" view, so the text is vertically centered in the widget's "row" as you'd desire it to in the main file view. We can make the widget 8px taller, adding 4px above and below so there's adequate room for the capacitybar, but that wastes 4px for each mount point. Ideally we'd use the "compact" view, which displays the text/size in a column beside the icon. However the compact view was not designed to take up the entire width of the viewport. It's also designed to overflow with a horizontal scrollbar.
2020-11-04Improve padding in the Places ViewEzike Ebuka
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-10-23Compile without foreachAlexander Lohnau
2020-10-23Show home folder if needed after unmounting mounted diskNate Graham
Right now, when you unmount a device that any active view containers are displaying, nothing in the view changes. As a result, it's possible to try to navigate to files or folders in that view, which cannot be done because the disk that the files or folders are located on has been unmounted! With this commit, we detect that case and switch the view containers to show the home folder after the disk whose contents they are displaying gets unmounted. BUG: 158934 FIXED-IN: 20.12
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-06-23Merge branch 'release/20.04'Alexander Lohnau
2020-06-22Generalize Player protocol supportKai Uwe Broulik
In preparation for AFC support in KFilePlacesModel. This needs to go into stable since otherwise once Solid announces AFC devices Dolphin would see them but try to open them as MTP URL
2020-06-16Places: Use Solid::Device::DisplayName for DisplayRoleMéven Car
Summary: BUG: 415281 FIXED-IN: 20.08 Counter-part of D26113 Test Plan: Before: {F8215025} After: {F8215027} Reviewers: ngraham, #dolphin Reviewed By: ngraham, #dolphin Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26114
2020-02-12Swap "Open in New Window" and "Open in New Tab" in context menusIlya Bizyaev
Summary: Since Dolphin's default behaviour became opening in new tabs rather than in new windows (a very positive change, in my opinion), I always find myself accidentally opening folders in new windows from the context menu. This is because in most browsers with tab workflow (e.g. Firefox, Chromium, Falkon) the top context menu action is opening in a new tab, and my muscle memory plays a bad trick :) I'm aware of middle-clicking, but I find it inconvenient with my touchpad. I suspect I'm probably not alone in that, so I think it makes sense to swap these actions in Dolphin to match widely used apps. Test Plan: Open Dolphin, right click folders in the main view and in the Places panel, ensure the actions are indeed swapped Reviewers: #vdg, ndavis, #dolphin, ngraham Reviewed By: #vdg, ndavis, #dolphin, ngraham Subscribers: ngraham, ndavis, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D27318
2019-11-19Port deprecated methodsLaurent Montel
2019-11-16Use URLs with transport encryptionYuri Chornoivan
2019-11-10PlacesItemModel: remove redundant set of propertiesElvis Angelaccio
Summary: The text, icon and url properties are already set in `PlacesItem::setBookmark()`, so there is no need to set them here. The `OnlyInApp` property is part of the KBookmark object that we are going to set to the place item, so there is no need to set it here either. Test Plan: - Open both dolphin and the Plasma file dialog in some app - Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog - Check whether the place in dolphin keeps getting updated accordingly Reviewers: #dolphin, meven, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25230
2019-11-09Remove unnecessary semicolons after Q_UNUSEDElvis Angelaccio
GIT_SILENT
2019-11-09Fix clazy non-pod-global-static warningElvis Angelaccio
This list of URLs is only used by cleanupBookmarks(), so there is no need to make it global (which is what clazy complains about). While at it, make it also a `const QVector`.
2019-10-27Unmounting busy device doesn't tell who is blockingDavid Hallas
Summary: Unmounting a busy device from the places panel doesn't tell which applications have open files blocking the unmount. Test Plan: Mount a USB stick using Dolphin Open a file from the USB stick Unmount the USB stick using Dolphin Observe the new error message. FEATURE: 189302 Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven Reviewed By: #dolphin, elvisangelaccio, meven Subscribers: meven, davidedmundson, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19989
2019-09-08GIT_SILENT: minor qstring optimizationLaurent Montel
2019-09-04Use better-named visible and hidden iconsNate Graham
2019-06-04Merge branch 'Applications/19.04'Kai Uwe Broulik
2019-06-04[Places Panel] Pass iconName to KFilePlaceEditDialogKai Uwe Broulik
Ensures that editing an entry with a custom icon doesn't have its icon discarded. Differential Revision: https://phabricator.kde.org/D21558
2019-05-12Fix indentationElvis Angelaccio
GIT_SILENT
2019-03-24Move Safely Remove down in places context menuTigran Gabrielyan
Summary: BUG: 405620 Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19950
2019-03-20Fix rearranging items in places panel with hidden itemsTigran Gabrielyan
Summary: `m_sourceModel->movePlace` is called using index from the view model. This becomes an issue when there are hidden places items. This change calls `m_sourceModel->movePlace` using the corresponding mapped source index. BUG: 399430 FIXED-IN: 19.04.0 Test Plan: # Create at least 4 Places items # Hide first item # Drag the now first visible item between second and third item Actual: The item does not move Expected: The first visible item should now be second visible item in the list Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19901
2019-02-27remove deprecated methodsLaurent Montel
2018-12-02[PlacesPanel] Fix unused variable warningElvis Angelaccio
2018-11-24[PlacesPanel] Port to KFilePlaceEditDialogElvis Angelaccio
Summary: This patch ports away from the old PlacesItemEditDialog copy, which doesn't honour the "applicationLocal" checkbox. KFilePlaceEditDialog was not exported by KIO, but it will be starting from 5.53 BUG: 376619 FIXED-IN: 19.03.80 Test Plan: * Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox * Edit an existing (global) place and check the "only show in dolphin" checkbox Reviewers: #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16824
generated by cgit v1.3 (git 2.53.0) at 2026-05-06 05:51:36 +0000