┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/places
AgeCommit message (Collapse)Author
2018-11-17Do not disconnect all StorageAccess signals when unmountingThomas Surrel
Summary: The problem is caused by the fact device interfaces returned by Solid (e.g. item->device().as<Solid::StorageAccess>()) are not full objects, but only references/pointers to a per-device-object, i.e. requesting the same interface for a device will return the same address every time. If the interface is used used in multiple places, calling disconnect on the interface address disconnects the signals for all users. BUG: 400992 Test Plan: In Dolphin, mount a local partition (e.g. a Windows partition) then unmount it (right click on it in Places, then Unmount). Try to access it again by clicking on it in Places, we should get access to it correctly. Reviewers: #dolphin, #frameworks, bruns, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16857
2018-11-17Improve Ux for the places panel's hidden itemsChris Rizzitello
Summary: BUG: 400860 FIXED-IN: 18.12.0 Clean up the context menu for the places panel. - Change Text "Show All Entries" -> "Show Hidden Places" - Use State dependent icon (like hidden files) - Disable instead of hide if not places are hidden. - Toggle to unchecked if last item of group is unhidden. Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places. Test Plan: With Hidden Places {F6398756} {F6398759} Context Menu: {F6398762} {F6398761} Without Hidden Places. {F6414694} {F6414696} Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel Tags: #dolphin Maniphest Tasks: T8349 Differential Revision: https://phabricator.kde.org/D16767
2018-10-25Fix minor typosYuri Chornoivan
2018-10-14Add a 'Properties' entry in the Places panel context menuThomas Surrel
Summary: BUG: 181880 Test Plan: Right-click on a place or on a device in the Places panel now show a Properties entry. Clicking on it will open its folder property. Reviewers: #dolphin, #plasma, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, cfeck, ngraham, abetts, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15929
2018-10-13[PlacesItemModelTest] Revert last two commitsElvis Angelaccio
Commit c527dc2172 proves that on the CI sometimes the `QAbstractItemModel::dataChanged` signal is not being emitted at all (build #208 failed because the test timed out). KFilePlacesModel emits `dataChanged()` in the `_k_reloadBookmarks()` slot only when it's called after the KBookmarkManager emits the `changed()` signal. And the `changed()` signal is emitted after KDirWatch emits the `created` signal. On the CI server kdirwatch is probably not reliable, which would explain why the test randomly fails.
2018-10-13[PlacesItemModelTest] Try to use an event loop instead of an hardcoded timeoutElvis Angelaccio
Increasing the timeout from 5 to 10 seconds didn't work. Let's see if an eventloop does the job.
2018-10-11Disable unmount option for / or /homeThomas Surrel
Summary: This removes the 'Unmount' context menu in the Places panel for discs corresponding to / and /home. It does not make much sense to offer an option that will always fail. BUG: 399659 Reviewers: #dolphin, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: sefaeyeoglu, elvisangelaccio, ngraham, broulik, bruns, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15989
2018-10-09Added missing icons to panel places itemsAlex Debus
Summary: Screenshots of the changes: | {F6310217} |{F6310218} This contribution was motivated by a comment on [[ https://pointieststick.wordpress.com/2018/10/06/this-week-in-usability-productivity-part-39/comment-page-1/#comment-2108 | Nate's blog]]. Reviewers: #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16019
2018-10-09Added missing QStringLiteral to Dolphin codeAlex Debus
Summary: Changed ``` QIcon::fromTheme("icon") ``` to ``` QIcon::fromTheme(QStringLiteral("edit-entry")) ``` as [[ https://phabricator.kde.org/D16019#339284 | discussed here ]]. Reviewers: ngraham, #dolphin, elvisangelaccio Reviewed By: ngraham, #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16050
2018-10-07Add 'Mount' option to context menu of unmounted device in PlacesThomas Surrel
Summary: This is only a proposal but: 1/ it the sysmetric of the Unmount entry in the context menu of mounted devices 2/ I have to admit it took me a very long time to discover (by accident) that you can just (left-)click on a unmounted device to get it mounted automatically. I might not be the only feeling that you should be able to mount a device from the context menu ... Twin of D15988 in Kio while dolphin is not based on the kio code for Places. {F6306516} Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15974
2018-10-04[PlacesItemModel] Update apidoxElvis Angelaccio
Should have been part of da6f8fe0862585287153 (the grouping feature has been moved upstream to KIO).
2018-10-04[PlacesItemModel] Drop unused forward declarationElvis Angelaccio
No longer needed since da6f8fe0862585287153f0d90e. GIT_SILENT
2018-10-04[PlacesItemModel] Drop dead codeElvis Angelaccio
m_bookmarkedItems is long gone (since commit da6f8fe0862585287153). Porting `showModelState()` to the new KFilePlacesModel source model is not worth it, since this was just a debugging function and most of the logic has been moved upstream anyway (see T7040).
2018-10-04Change icon for the 'Edit...' context menu entry in Places panelThomas Surrel
Summary: The current icon is used for displaying the Properties context menu in other places in dolphin. Change to edit-entry. Test Plan: Right-click on a place in the Places panel. Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15938
2018-09-24[Places Panel] Cleanup includesKai Uwe Broulik
Some leftovers from when Dolphin managed the places entirely on its own Differential Revision: https://phabricator.kde.org/D15636
2018-08-04Remove custom icon selection for trashShubham Jangra
Summary: CCBUG: 391200 Test Plan: 1. Open Dolphin 2. Edit trash in places item Result: No custom icon option available Reviewers: ngraham, #dolphin, broulik, pino, elvisangelaccio, cfeck Reviewed By: ngraham, #dolphin, elvisangelaccio, cfeck Subscribers: rkflx, cfeck, elvisangelaccio, pino, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D14378
2018-06-22Use copy ellisionTomaz Canabrava
2018-06-22Remove unused variableTomaz Canabrava
Compiled, Run. Trash still there.
2018-06-03Merge branch 'Applications/18.04'Elvis Angelaccio
2018-06-03Fix crash in PlacesItem::setUrl()Elvis Angelaccio
Connections to lambda slots without context/receiver argument can lead to crashes, because if the receiver is deleted Qt won't delete the connection as it normally would when the receiver is specified. This patch moves the slot from the lambda in PlacesItem (which is not a QObject) to PlacesItemSignalHandler. This fixes the `dolphinmainwindowtest` crash we currently have on master, and should also fix bug #394507 which has the very same stacktrace. BUG: 394507 FIXED-IN: 18.04.2
2018-04-29Merge branch 'Applications/18.04'Antonio Rojas
2018-04-29Don't filter out duplicated entries from places panelAntonio Rojas
This can lead to crashes and is inconsistent with the KIO file picker dialog, which shows duplicated entries. BUG: 393528 Differential Revision: https://phabricator.kde.org/D12558
2018-04-12Merge branch 'Applications/18.04'Antonio Rojas
2018-04-12Fix untranslated places panel entriesAntonio Rojas
Load the places panel entries strings from the kio5 catalog, where they live now BUG: 392822 Differential Revision: https://phabricator.kde.org/D12119
2018-04-01Split Image Size into Width/HeightJulian Schraner
Summary: This patch splits the single property "Image Size" into "Width" and "Height", providing more fine-tuned control for power users. FEATURE: 374559 Test Plan: - Sorting works correctly - No real change, only exposed differently Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, elvisangelaccio Differential Revision: https://phabricator.kde.org/D11816
2018-04-01Fix detachingElvis Angelaccio
2018-04-01Use QHash rather than QMapElvis Angelaccio
As recommended by the clazy qmap-with-pointer-key check.
2018-03-19Introduce singleton for KFilePlacesModelKai Uwe Broulik
There are various places where Dolphin created a new KFilePlacesModel which would then query all storage devices and do other expensive work. Differential Revision: https://phabricator.kde.org/D11283
2018-03-11Removed unused variables spotted by clazyElvis Angelaccio
2018-03-11Add Trash (empty, isEmpty, emptinessChanged)Roman Inflianskas
Summary: Add `Trash` class to handle all trash operations. Reviewers: elvisangelaccio, markg, ngraham Reviewed By: elvisangelaccio, markg, ngraham Subscribers: ngraham, markg, rkflx, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D11012
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-02-03Fix all 'explicit constructor' krazy warningsElvis Angelaccio
2018-01-26Fix place item edit after creationRenato Araujo Oliveira Filho
Summary: Make sure that the place can be edited after the creation. Depends on D9333 BUG: 389147 Test Plan: Create an item in dolphin places panel, make sure that you can rename it Reviewers: #dolphin, ngraham Reviewed By: ngraham Subscribers: michaelh, elvisangelaccio, lbeltrame, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9985
2018-01-26Make sure that old URLs do not appear duplicated in places modelRenato Araujo Oliveira Filho
Summary: BUG: 389401 KIO model now provides Baloo URLs; we need to remove the old ones created by Dolphin places model BUG: 387888 Depends on D9332 Test Plan: unit test Reviewers: mwolff, #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, broulik, ervin, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9333
2018-01-19Revert "Ignore baloo urls created from new KIO model"Luca Beltrame
This reverts commit 9d3a019445d7a7fdf3177bca9eeef4c44599e706. Causes breakage in Dolphin in master. The proper fix is in D9333. CCBUG: 389147
2018-01-18Merge remote-tracking branch 'origin/Applications/17.12'Luca Beltrame
Conflicts: CMakeLists.txt [versions] src/panels/places/placesitemmodel.cpp
2018-01-11Explicitly pass iconNameForUrl when dropping places entryKai Uwe Broulik
Differential Revision: https://phabricator.kde.org/D9609
2018-01-08Fix PlacesItemModel loading with hidden devicesRenato Araujo Oliveira Filho
Summary: Make sure that hidden devices loaded after module initialization does not appear in the view. Check for item visibility before add it on the model. Test Plan: Unit test created Reviewers: franckarrecot Reviewed By: franckarrecot Subscribers: cfeck, ervin, #dolphin Differential Revision: https://phabricator.kde.org/D9441
2018-01-02Ignore baloo urls created from new KIO modelRenato Araujo Oliveira Filho
Summary: For now ignore baloo urls that was created by new KIO::KFilePlacesModel, until we make use of new KIO API. BUG: 387888 Test Plan: Open any KIO file dialog using the new API. Runs dolphin v17.12.0 Make sure that baloo urls does not appear duplicated Reviewers: ngraham, elvisangelaccio Reviewed By: ngraham, elvisangelaccio Subscribers: cfeck, elvisangelaccio, ervin, mlaurent, #dolphin Differential Revision: https://phabricator.kde.org/D9347
2017-12-14Implemented support for hide/show groupsRenato Araujo Oliveira Filho
Summary: Added an option on PlacesPanel context menu to show or hide the entire group of places. Depends on D8855 Test Plan: Open Donlphin and use PlacesPanel context menu to hide and show groups Reviewers: franckarrecot, mlaurent, mwolff, elvisangelaccio Reviewed By: franckarrecot, mlaurent, mwolff, elvisangelaccio Subscribers: rkflx, mwolff, elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9242
2017-12-14Use Kio::KPlacesModel as source model for PlacesItemModelRenato Araujo Oliveira Filho
Summary: Use Kio::KPlacesModel as source model for PlacesItemModel avoiding duplicated code. Depends on D8862 Depends on D8332 Depends on D8434 Depends on D8348 Depends on D8630 Test Plan: Unit test created Reviewers: elvisangelaccio, emmanuelp, mlaurent, mwolff Reviewed By: elvisangelaccio, mlaurent, mwolff Subscribers: mwolff, mlaurent, anthonyfieroni, nicolasfella, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8855
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2017-11-11Prevent folders from drag and dropping onto themselves in dolphin main viewEmirald Mateli
Summary: This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself. The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior. BUG: 307747 Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen. {F3787651} Test Plan: 1. Drag a folder. 2. Drop it onto itself. Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror Tags: #dolphin Differential Revision: https://phabricator.kde.org/D6281
2017-11-03Use nullptr + add explicit keywordMontel Laurent
Test Plan: compile Reviewers: #dolphin, broulik Reviewed By: broulik Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D8637
2017-10-12Don't block unmounting when terminal panel's cwd is the mountpointMiklos Marton
When unmounting a removable media Dolphin checks if there are some files open on the device before performing the unmount. If the terminal window in dolphin is open and the to be unmounted path is open, the unmount process will be blocked. This patch sets the terminal window current path to the home directory upon unmount request if the terminal directory is set to the mount path. The unmount request could came from two sources: The user could hit right click on the media in the dolphin's places panel and hit unmount. The user could request an unmount from the indicator applet This patch was originally written by Arjun AK for the kdelibs4 version of Dolphin: https://git.reviewboard.kde.org/r/121613/ BUG: 158264 FIXED-IN: 17.11.80 Differential Revision: https://phabricator.kde.org/D7847
2017-09-11Add "Open in New Window to Dolphin's places context menuNathaniel Graham
Summary: BUG: 384352 Add an "Open in New Window" menu item to the context menu for Dolphin's places items. Test Plan: Tested in up-to-date KDE Neon. Works as expected: {F3898707} Reviewers: #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio, emmanuelp, broulik Reviewed By: #dolphin, emmanuelp, broulik Subscribers: alexeymin, emmanuelp, broulik, sefaeyeoglu, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D7690
2017-08-23Fix typo in udi stringChristoph Feck
Spotted by Chris Holland. BUG: 383182
2017-06-27[Places Panel] Disallow editing devicesKai Uwe Broulik
I introduced this bug when I changed the layout of the menu. While it would be nice if one could edit devices, it is currently not possible and would require significant re-engineering effort in Solid. While the "Edit" menu works just fine, changes are not persisted. Reviewed-By: emmanuelp Differential Revision: https://phabricator.kde.org/D6294
generated by cgit v1.3 (git 2.53.0) at 2026-05-06 11:08:47 +0000