┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/places
AgeCommit message (Collapse)Author
2020-11-04Only show capacity bar for devices (has a udi).Chris Holland
2020-11-04Only check if place url is mount point once during polish event.Chris Holland
The capacity bars will no longer update when capacity changes. It only checks the size on init. Updating during polish event is only a temporarily solution just to draft code flow for seperating logic from painting. Eventually this logic update should be in a worker thread detached from blocking the rendering thread that blocks launching the dolphin window.
2020-11-04Draw 2 Rectangles below mount points to represent a disk capacity barChris Holland
Draws overtop text that's goes below the baseline like a 'j'. It's fairly difficult to add extra space below the text as the places view is a "details" view, so the text is vertically centered in the widget's "row" as you'd desire it to in the main file view. We can make the widget 8px taller, adding 4px above and below so there's adequate room for the capacitybar, but that wastes 4px for each mount point. Ideally we'd use the "compact" view, which displays the text/size in a column beside the icon. However the compact view was not designed to take up the entire width of the viewport. It's also designed to overflow with a horizontal scrollbar.
2020-11-04Improve padding in the Places ViewEzike Ebuka
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-10-23Compile without foreachAlexander Lohnau
2020-10-23Show home folder if needed after unmounting mounted diskNate Graham
Right now, when you unmount a device that any active view containers are displaying, nothing in the view changes. As a result, it's possible to try to navigate to files or folders in that view, which cannot be done because the disk that the files or folders are located on has been unmounted! With this commit, we detect that case and switch the view containers to show the home folder after the disk whose contents they are displaying gets unmounted. BUG: 158934 FIXED-IN: 20.12
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-06-23Merge branch 'release/20.04'Alexander Lohnau
2020-06-22Generalize Player protocol supportKai Uwe Broulik
In preparation for AFC support in KFilePlacesModel. This needs to go into stable since otherwise once Solid announces AFC devices Dolphin would see them but try to open them as MTP URL
2020-06-16Places: Use Solid::Device::DisplayName for DisplayRoleMéven Car
Summary: BUG: 415281 FIXED-IN: 20.08 Counter-part of D26113 Test Plan: Before: {F8215025} After: {F8215027} Reviewers: ngraham, #dolphin Reviewed By: ngraham, #dolphin Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26114
2020-02-12Swap "Open in New Window" and "Open in New Tab" in context menusIlya Bizyaev
Summary: Since Dolphin's default behaviour became opening in new tabs rather than in new windows (a very positive change, in my opinion), I always find myself accidentally opening folders in new windows from the context menu. This is because in most browsers with tab workflow (e.g. Firefox, Chromium, Falkon) the top context menu action is opening in a new tab, and my muscle memory plays a bad trick :) I'm aware of middle-clicking, but I find it inconvenient with my touchpad. I suspect I'm probably not alone in that, so I think it makes sense to swap these actions in Dolphin to match widely used apps. Test Plan: Open Dolphin, right click folders in the main view and in the Places panel, ensure the actions are indeed swapped Reviewers: #vdg, ndavis, #dolphin, ngraham Reviewed By: #vdg, ndavis, #dolphin, ngraham Subscribers: ngraham, ndavis, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D27318
2019-11-19Port deprecated methodsLaurent Montel
2019-11-16Use URLs with transport encryptionYuri Chornoivan
2019-11-10PlacesItemModel: remove redundant set of propertiesElvis Angelaccio
Summary: The text, icon and url properties are already set in `PlacesItem::setBookmark()`, so there is no need to set them here. The `OnlyInApp` property is part of the KBookmark object that we are going to set to the place item, so there is no need to set it here either. Test Plan: - Open both dolphin and the Plasma file dialog in some app - Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog - Check whether the place in dolphin keeps getting updated accordingly Reviewers: #dolphin, meven, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25230
2019-11-09Remove unnecessary semicolons after Q_UNUSEDElvis Angelaccio
GIT_SILENT
2019-11-09Fix clazy non-pod-global-static warningElvis Angelaccio
This list of URLs is only used by cleanupBookmarks(), so there is no need to make it global (which is what clazy complains about). While at it, make it also a `const QVector`.
2019-10-27Unmounting busy device doesn't tell who is blockingDavid Hallas
Summary: Unmounting a busy device from the places panel doesn't tell which applications have open files blocking the unmount. Test Plan: Mount a USB stick using Dolphin Open a file from the USB stick Unmount the USB stick using Dolphin Observe the new error message. FEATURE: 189302 Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven Reviewed By: #dolphin, elvisangelaccio, meven Subscribers: meven, davidedmundson, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19989
2019-09-08GIT_SILENT: minor qstring optimizationLaurent Montel
2019-09-04Use better-named visible and hidden iconsNate Graham
2019-06-04Merge branch 'Applications/19.04'Kai Uwe Broulik
2019-06-04[Places Panel] Pass iconName to KFilePlaceEditDialogKai Uwe Broulik
Ensures that editing an entry with a custom icon doesn't have its icon discarded. Differential Revision: https://phabricator.kde.org/D21558
2019-05-12Fix indentationElvis Angelaccio
GIT_SILENT
2019-03-24Move Safely Remove down in places context menuTigran Gabrielyan
Summary: BUG: 405620 Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19950
2019-03-20Fix rearranging items in places panel with hidden itemsTigran Gabrielyan
Summary: `m_sourceModel->movePlace` is called using index from the view model. This becomes an issue when there are hidden places items. This change calls `m_sourceModel->movePlace` using the corresponding mapped source index. BUG: 399430 FIXED-IN: 19.04.0 Test Plan: # Create at least 4 Places items # Hide first item # Drag the now first visible item between second and third item Actual: The item does not move Expected: The first visible item should now be second visible item in the list Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19901
2019-02-27remove deprecated methodsLaurent Montel
2018-12-02[PlacesPanel] Fix unused variable warningElvis Angelaccio
2018-11-24[PlacesPanel] Port to KFilePlaceEditDialogElvis Angelaccio
Summary: This patch ports away from the old PlacesItemEditDialog copy, which doesn't honour the "applicationLocal" checkbox. KFilePlaceEditDialog was not exported by KIO, but it will be starting from 5.53 BUG: 376619 FIXED-IN: 19.03.80 Test Plan: * Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox * Edit an existing (global) place and check the "only show in dolphin" checkbox Reviewers: #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16824
2018-11-17Merge remote-tracking branch 'origin/Applications/18.12'Thomas Surrel
2018-11-17Do not disconnect all StorageAccess signals when unmountingThomas Surrel
Summary: The problem is caused by the fact device interfaces returned by Solid (e.g. item->device().as<Solid::StorageAccess>()) are not full objects, but only references/pointers to a per-device-object, i.e. requesting the same interface for a device will return the same address every time. If the interface is used used in multiple places, calling disconnect on the interface address disconnects the signals for all users. BUG: 400992 Test Plan: In Dolphin, mount a local partition (e.g. a Windows partition) then unmount it (right click on it in Places, then Unmount). Try to access it again by clicking on it in Places, we should get access to it correctly. Reviewers: #dolphin, #frameworks, bruns, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16857
2018-11-17Merge remote-tracking branch 'origin/Applications/18.12'Chris Rizzitello
2018-11-17Improve Ux for the places panel's hidden itemsChris Rizzitello
Summary: BUG: 400860 FIXED-IN: 18.12.0 Clean up the context menu for the places panel. - Change Text "Show All Entries" -> "Show Hidden Places" - Use State dependent icon (like hidden files) - Disable instead of hide if not places are hidden. - Toggle to unchecked if last item of group is unhidden. Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places. Test Plan: With Hidden Places {F6398756} {F6398759} Context Menu: {F6398762} {F6398761} Without Hidden Places. {F6414694} {F6414696} Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel Tags: #dolphin Maniphest Tasks: T8349 Differential Revision: https://phabricator.kde.org/D16767
2018-11-11[PlacesItem] Add support for OnlyInApp metadata for bookmarksElvis Angelaccio
This will allow to edit an existing place to make it application-local or visible from all applications. CCBUG: 376619
2018-11-11[PlacesItemModel] Match KFilePlacesModel addPlaces() APIElvis Angelaccio
This will allow to create a place visible only from Dolphin, by passing an `appName` to the KFilePlacesModel. CCBUG: 376619
2018-10-25Fix minor typosYuri Chornoivan
2018-10-14Add a 'Properties' entry in the Places panel context menuThomas Surrel
Summary: BUG: 181880 Test Plan: Right-click on a place or on a device in the Places panel now show a Properties entry. Clicking on it will open its folder property. Reviewers: #dolphin, #plasma, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, cfeck, ngraham, abetts, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15929
2018-10-13[PlacesItemModelTest] Revert last two commitsElvis Angelaccio
Commit c527dc2172 proves that on the CI sometimes the `QAbstractItemModel::dataChanged` signal is not being emitted at all (build #208 failed because the test timed out). KFilePlacesModel emits `dataChanged()` in the `_k_reloadBookmarks()` slot only when it's called after the KBookmarkManager emits the `changed()` signal. And the `changed()` signal is emitted after KDirWatch emits the `created` signal. On the CI server kdirwatch is probably not reliable, which would explain why the test randomly fails.
2018-10-13[PlacesItemModelTest] Try to use an event loop instead of an hardcoded timeoutElvis Angelaccio
Increasing the timeout from 5 to 10 seconds didn't work. Let's see if an eventloop does the job.
2018-10-11Disable unmount option for / or /homeThomas Surrel
Summary: This removes the 'Unmount' context menu in the Places panel for discs corresponding to / and /home. It does not make much sense to offer an option that will always fail. BUG: 399659 Reviewers: #dolphin, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: sefaeyeoglu, elvisangelaccio, ngraham, broulik, bruns, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15989
2018-10-09Added missing icons to panel places itemsAlex Debus
Summary: Screenshots of the changes: | {F6310217} |{F6310218} This contribution was motivated by a comment on [[ https://pointieststick.wordpress.com/2018/10/06/this-week-in-usability-productivity-part-39/comment-page-1/#comment-2108 | Nate's blog]]. Reviewers: #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16019
2018-10-09Added missing QStringLiteral to Dolphin codeAlex Debus
Summary: Changed ``` QIcon::fromTheme("icon") ``` to ``` QIcon::fromTheme(QStringLiteral("edit-entry")) ``` as [[ https://phabricator.kde.org/D16019#339284 | discussed here ]]. Reviewers: ngraham, #dolphin, elvisangelaccio Reviewed By: ngraham, #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16050
2018-10-07Add 'Mount' option to context menu of unmounted device in PlacesThomas Surrel
Summary: This is only a proposal but: 1/ it the sysmetric of the Unmount entry in the context menu of mounted devices 2/ I have to admit it took me a very long time to discover (by accident) that you can just (left-)click on a unmounted device to get it mounted automatically. I might not be the only feeling that you should be able to mount a device from the context menu ... Twin of D15988 in Kio while dolphin is not based on the kio code for Places. {F6306516} Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15974
2018-10-04[PlacesItemModel] Update apidoxElvis Angelaccio
Should have been part of da6f8fe0862585287153 (the grouping feature has been moved upstream to KIO).
2018-10-04[PlacesItemModel] Drop unused forward declarationElvis Angelaccio
No longer needed since da6f8fe0862585287153f0d90e. GIT_SILENT
2018-10-04[PlacesItemModel] Drop dead codeElvis Angelaccio
m_bookmarkedItems is long gone (since commit da6f8fe0862585287153). Porting `showModelState()` to the new KFilePlacesModel source model is not worth it, since this was just a debugging function and most of the logic has been moved upstream anyway (see T7040).
2018-10-04Change icon for the 'Edit...' context menu entry in Places panelThomas Surrel
Summary: The current icon is used for displaying the Properties context menu in other places in dolphin. Change to edit-entry. Test Plan: Right-click on a place in the Places panel. Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15938
2018-09-24[Places Panel] Cleanup includesKai Uwe Broulik
Some leftovers from when Dolphin managed the places entirely on its own Differential Revision: https://phabricator.kde.org/D15636
2018-08-04Remove custom icon selection for trashShubham Jangra
Summary: CCBUG: 391200 Test Plan: 1. Open Dolphin 2. Edit trash in places item Result: No custom icon option available Reviewers: ngraham, #dolphin, broulik, pino, elvisangelaccio, cfeck Reviewed By: ngraham, #dolphin, elvisangelaccio, cfeck Subscribers: rkflx, cfeck, elvisangelaccio, pino, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D14378
2018-06-22Use copy ellisionTomaz Canabrava
2018-06-22Remove unused variableTomaz Canabrava
Compiled, Run. Trash still there.
generated by cgit v1.3 (git 2.53.0) at 2026-04-25 01:06:27 +0000