| Age | Commit message (Collapse) | Author |
|---|
|
|
|
When a user selects a custom font via the font dialog, the font mode combobox (showing System Font / Custom Font) was updated to use the selected font.
This caused an unintended visual inconsistency, as configuration UI elements should always be rendered using the system application font, independent of the font chosen for the content view.
Fix this by removing the setFont() call in openFontDialog(), ensuring the combobox remains visually consistent with the rest of the configuration interface.
BUG: 499783
|
|
The font selection dialog for custom view fonts was always initialized with
the system default font instead of the previously selected custom font.
This occurred because QFontDialog::getFont() was not passed the current
custom font stored in DolphinFontRequester.
By initializing the dialog with currentFont() (which returns the stored
custom font when in Custom Font mode), users will now see their previous
font selection when reopening the dialog, enabling easier font finetuning.
BUG: 499786
|
|
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
|
|
Better for screen readers etc.
|
|
|
|
By defining the KF_DISABLE_DEPRECATED_BEFORE_AND_AT and QT_DISABLE_DEPRECATED_BEFOREvalues,
the deprecated overloads are hidden. This way we only have the un-deprecated one visible.
|
|
|
|
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
|
|
|
|
|
|
Summary: None of Dolphin's current usages of `KComboBox` use any of its additional features beyond `QComboBox`, so let's use `QComboBox` instead.
Test Plan: Tested all features that use comboboxes in Dolphin. No visual or functional changes or regressions.
Reviewers: #dolphin, elvisangelaccio, broulik
Reviewed By: #dolphin, elvisangelaccio
Subscribers: broulik, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D13749
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
|
|
present, because KFileMetaDataWidget is in KDELibs4Support)
Reviewed-By: Vishesh Handa
|
|
|
|
|
|
|
|
|
|
|
|
- Handle 'Context Menu' settings as part of the services
- Handle 'Version Control' settings as part of the services
- Move the confirmations-settings into own tab
- Use combobox for view-property settings
- A lot of minor spacing cleanups
|
|
|
|
|
|
Also some KDE-includes have been capitalized
|
|
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1154129
|
