┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/settings
AgeCommit message (Collapse)Author
2019-12-16SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-12-15Don't overload the word "Properties" to mean multiple thingsNate Graham
Summary: Generally "Properties" refers to information about a selected file. However Dolphin also uses the word "Properties" in the phrase "View Properties", which refers to the display style of the view. Since "properties" is a fairly esoteric and technical term to most users, it would probably be wise to avoid using it in multiple contexts. Accordingly, this patch changes "view properties" to "view display style". Test Plan: Look at the settings window, hamburger menu, view menu, and docbook Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio Subscribers: ndavis, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D25987
2019-12-09Merge branch 'release/19.12'Antonio Rojas
2019-12-09Fix build with Qt 5.14 RCAntonio Rojas
Add needed Qt includes that are no longer pulled transitively. BUG: 414492 Differential Revision: https://phabricator.kde.org/D25783
2019-12-06Make it compile against last kf5 version without deprecated methodsLaurent Montel
2019-11-19Change default completion mode to CompletionPopupAutoNoah Davis
Summary: This makes Dolphin use the "Dropdown List & Automatic" completion mode by default when editing the URL bar. Given the context of someone typing file paths, I can't see why one wouldn't want to use this feature, unless they don't like how it looks. Reviewers: #vdg, #dolphin, ngraham, elvisangelaccio Reviewed By: #vdg, #dolphin, ngraham, elvisangelaccio Subscribers: ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25391
2019-11-16Use URLs with transport encryptionYuri Chornoivan
2019-11-11SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-11SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-09Remove unnecessary semicolons after Q_UNUSEDElvis Angelaccio
GIT_SILENT
2019-11-09Fix clazy inefficient-qlist-soft warningElvis Angelaccio
2019-10-28Fix minor issues found by EBNYuri Chornoivan
2019-10-28SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-29Expose full set of script execution options in settings windowNate Graham
Summary: Right now the script execution setting is a checkbox, capable only of handling boolean input. This is not appropriate because there are actually three options available. Accordingly, this patch replaces the checkbox with a combobox (to save space compared to radio buttons) that clearly exposes all three options. BUG: 371837 FIXED-IN: 19.12.0 Test Plan: {F7440559} - All three options do what they say they'll do - All options get saved properly - The combobox displays the correct option when the window is loaded - The {nav Defaults} button resets it to "always ask" as expected Reviewers: elvisangelaccio, #dolphin, #vdg Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T9932 Differential Revision: https://phabricator.kde.org/D24247
2019-09-25SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-08GIT_SILENT: minor qstring optimizationLaurent Montel
2019-09-06Use large colorful category icons in Dolphin settingsBjörn Feber
Summary: {F7324074} Ref task T10165 Depends on D23749 Test Plan: Open the Dolphin settings dialog. Reviewers: #dolphin, #vdg, ndavis, ngraham Reviewed By: #dolphin, #vdg, ndavis, ngraham Subscribers: ngraham, ndavis, kfm-devel, #vdg, #dolphin Tags: #dolphin Maniphest Tasks: T10165 Differential Revision: https://phabricator.kde.org/D23750
2019-08-19Fix a typoNazar Kalinowski
Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23264
2019-07-31SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-21Merge branch 'Applications/19.08'Alexander Potashev
2019-07-21servicemenuinstaller: Fix placeholders in i18n stringAlexander Potashev
Test Plan: it compiles Reviewers: #dolphin, aacid Reviewed By: aacid Subscribers: aacid, ltoscano, kde-i18n-doc, kfm-devel, #localization Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22597
2019-07-16Merge branch 'Applications/19.08'Alexander Potashev
2019-07-16servicemenuinstaller: Run installation scripts with cwd in their parent ↵Alexander Potashev
directories Summary: Otherwise, if cwd is set to the unpacked dir root, some service menus fail to install. Test Plan: - Successfully Installed and uninstalled the "Color Folder" service menu from "Configure Dolphin..." -> service menus -> KNewStuff. - ./test_run.rb still passes all its tests. Reviewers: elvisangelaccio, sitter Reviewed By: sitter Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22466
2019-07-15servicemenuinstaller: Use QMimeDatabase instead of running xdg-mimeAlexander Potashev
Test Plan: ./test_run.rb still passes all tests. Reviewers: elvisangelaccio, sitter, ngraham Reviewed By: elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22465
2019-07-15Rewrite servicemenu helper utility in C++Alexander Potashev
Summary: - Also support MIME type "application/x-compressed-tar". - Update tests in Ruby, remove SimpleCov. BUG: 399229 Test Plan: Ruby tests passed Reviewers: sitter, elvisangelaccio, ngraham Reviewed By: elvisangelaccio Subscribers: cfeck, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21878
2019-06-23Adding option to open externally called folder in a new tabAlexander Saoutkin
Summary: Adds an option to open externally called folder in a new tab. By default this option is enabled Test Plan: If option selected: 1. All valid arguments passed to Dolphin should be opened in tabs of an instance(s) (if it exists). Duplicate tabs just change activation to current tab. If option not selected: 1. All calls to Dolphin result in a new instance being opened This option does not require Dolphin to be restarted to take effect. Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, ngraham Subscribers: broulik, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21736
2019-05-22SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-05-12Fix stale commentElvis Angelaccio
GIT_SILENT
2019-05-08services/test: Fix testAlexander Potashev
Reviewers: #dolphin, elvisangelaccio, sitter Reviewed By: sitter Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21022
2019-05-05Get rid of ugly static_cast usages in connect() callsElvis Angelaccio
2019-03-27Fix typo in dolphinsettingsdialog.cppYi-Jyun Pan
Summary: Just remove the useless "have". Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20080
2019-03-26Prompt user to save/discard changes upon closing config dialogAmish Naidu
Summary: When the configuration dialog is closed with unsaved changes, a message box is prompted to save/discard them or cancel the event. BUG: 391206 Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19904
2019-03-18fix coverage generation when run through ctestHarald Sitter
path construction is a bit disappointing and doesn't actually work all that well for out-of-tree PWDs. in lieu of an upstream fix let's try our best to get the correct coverage directory set. without this hack no results get recorded unfortunately.
2019-03-18redo service menu ruby helpers from ground up more or lessHarald Sitter
Summary: - apply ruby community style guidelines - full rewrite fixing, among other things: - inefficient/unreadable String#end_with reimplementation - inefficient use of Kernel.system (forked shell to fork a shell) - inefficient/unreadable Dir.glob reimplementation - inefficient File initialization for single chmod - invocation conditions are now actually readable - invocation conditions now also force +x on argless scripts, not just scripts that need arguments - repetitive conditions are now expressed as loops on argument arrays - mime detection now uses xdg-mime instead of file (xdg-mime internally may fall back to mime but will prefer higher level tools such as kmimetypefinder5; giving better results overall) - return values of "backtick forks" are now checked and will produce suitable errors on stderr - fail now takes a log_msg argument which is printed to stderr. this is in addition to the error raised as notification for the user, as that is unfortunately not so useful for diagnostics - overall error handling and logging of problem causes is much improved - add license headers. the original code was actually fairly exhaustive, so this really should have had a header to begin with. the code was originally introduced in svn r1045663 on Nov 6 14:56:35 2009 UTC - add blackbox tests. in the interest of keeping the scripts actually simple scripts (as opposed to a bunch of classes used by even simpler scirpts) they are now also covered by test rigging which runs them as scripts (again, as opposed to individual unit testing of distinct units) - the tests optionally can use simplecov to gather coverage metrics - also wired up to ctest so it actually gets run structurally there is actually a fair amount of overlap between the two scripts, but again, in the interest of keeping things simple I think it's better to live with that instead of refactoring a shared library out of it and then use heavy-duty meta-programming Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19334
2019-03-17Make global view properties the default settingElvis Angelaccio
Summary: Automatic creation of .directory files is one of the most complained about things in dolphin. These days applications are supposed to store application-specific data within $XDG_DATA_HOME. Long-term that's the proper solution for this issue, but for now we can at least flip the default so that we no longer create .directory files out of the box. A tooltip is also added as a kind of warning for the users who want to change the setting. Ideally a proper warning should be shown using a KMessageWidget or KMessageBox, but neither play too well with the setting dialog workflow used by dolphin. CCBUG: 322922 Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19661
2019-03-10port to std::stable_sortLaurent Montel
2019-03-06Improve wording of split view/pane settingsSimon Depiets
Summary: I found these strings very hard to understand then translate without looking into the code because the use of "view" refers to both "the split view" and "the left pane and the right pane of the split view". This patch attempts to explicitly mention panes when needed. Reviewers: #dolphin, angeloevertonjr, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19579
2019-02-27remove deprecated methodsLaurent Montel
2019-02-22SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-16Add option to choose which view to closeAngelo Oliveira Jr
Summary: This Diff make configurable which view will close when toggling off the split view mode, if it's the active one or the inactive one. A new checkbox was added to the Dolphin configuration window, and defaults to the original behavior. FEATURE: 312834 FIXED-IN: 19.03.80 Test Plan: {F6535432} Reviewers: ngraham, #dolphin, elvisangelaccio Reviewed By: ngraham, #dolphin Subscribers: elvisangelaccio, cfeck, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18040
2019-02-06Merge branch 'Applications/18.12'Kai Uwe Broulik
2019-02-06Sort preview plugins case-insensitivelyKai Uwe Broulik
"eBook thumbnails" would show up all the way at the bottom otherwise Test Plan: 18.12 branch It now shows where it should Differential Revision: https://phabricator.kde.org/D18787
2019-01-28Introduce HAVE_TERMINALElvis Angelaccio
Source code should check for features detected during configure-time, rather than checking for a specific OS. See also commit 87e8d0ba5f.
2019-01-19Ask for confirmation when Closing Dolphin windows with a terminal panel ↵Nate Graham
running a program Summary: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program. FEATURE: 304816 FIXED-IN: 19.04.0 Test Plan: # Open terminal panel # Run `watch ls` # Close Dolphin # Observe confirmation # Disable confirmation # Repeat, observe no confirmation # Enable confirmation in the settings # Repeat, observe a confirmation Reviewers: #dolphin, markg, elvisangelaccio, rominf Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel, elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D10960
2019-01-06SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-01-06SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-27Adjust label in the settings page for changed preview behaviourFabian Vogt
Summary: Requested by https://phabricator.kde.org/D15138#318904 Test Plan: Opened the preview settings, label text changed. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ngraham, markg, broulik, kfm-devel, elvisangelaccio Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15216
2018-10-25Fix minor typosYuri Chornoivan
2018-09-04Merge branch 'Applications/18.08'David Edmundson
2018-09-04Correctly save behaviourOnLaunchDavid Edmundson
Summary: We only wrote out a checkbox value if the checkbox was checked. Unchecking it would not do anything. BUG: 398022 Test Plan: Read KRun's exepcted values Unchecked config option Reloaded dolphin Checkbox remained off Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15147
generated by cgit v1.3 (git 2.53.0) at 2026-04-25 13:47:53 +0000