| Age | Commit message (Collapse) | Author |
|
Summary:
Access the object by its existing name rather than renaming it.
BUG: 405780
FIXED-IN: 19.04.1
Test Plan:
- Add {nav Create New} item to toolbar; it now works
- Verify that {nav Create New} menu and toolbar items are disabled when in the trash
- All tests still pass
Reviewers: elvisangelaccio, broulik, #dolphin, cfeck
Reviewed By: cfeck
Subscribers: cfeck, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D20664
|
|
The newFileMenu enabled status is updated whenever the KDirLister emits
the `completed` signal: use QTRY_COMPARE so that we can wait for it.
|
|
Summary:
The DolphinTabPage::activeViewUrlChanged signal triggers the title
update in DolphinMainWindow, which sets the new title from the
`m_activeViewContainer` instance.
This means we need to notify the main window that the active view
changed before telling it that the current url changed.
BUG: 402641
FIXED-IN: 18.12.1
Reviewers: #dolphin, rizzitello, ngraham
Reviewed By: #dolphin, rizzitello, ngraham
Subscribers: rizzitello, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D17881
|
|
CCBUG: 402641
|
|
Both icon `name()`s are empty on the CI, which probably doesn't have
icons or something. This should hopefully fix it.
|
|
testOpenInNewTabTitle() is currently failing on the CI, this should help
investigate why.
|
|
|
|
Summary:
Root and Trash test cases are currently failing because of
commit e133c4557ecc37ed3f7e1b9418306aa8cc516865.
Reviewers: #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D16005
|
|
Fix will be in D15112.
CCBUG: 397910
|
|
We don't want to use the user configuration files when creating a test
instance of DolphinMainWindow.
|
|
We deactivate the previously active view container whenever we change the active
split view, but we never do the same when we close the split view.
Long term we should probably even delete the secondary view after
closing the split view, because it will never be used again and the
pointer will be overwritten the next time the user opens the split view.
|
|
Will be fixed by D12446.
CCBUG: 385111
|
|
|
|
For now it contains a test case for the crash in bug #379135
CCBUG: 379135
Reviewers: emmanuelp, dfaure
Differential Revision: https://phabricator.kde.org/D5936
|