┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views/dolphinviewactionhandler.cpp
AgeCommit message (Collapse)Author
2019-12-15Don't overload the word "Properties" to mean multiple thingsNate Graham
Summary: Generally "Properties" refers to information about a selected file. However Dolphin also uses the word "Properties" in the phrase "View Properties", which refers to the display style of the view. Since "properties" is a fairly esoteric and technical term to most users, it would probably be wise to avoid using it in multiple contexts. Accordingly, this patch changes "view properties" to "view display style". Test Plan: Look at the settings window, hamburger menu, view menu, and docbook Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio Subscribers: ndavis, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D25987
2019-11-09Remove unnecessary semicolons after Q_UNUSEDElvis Angelaccio
GIT_SILENT
2019-09-14Improve icons and text for some actionsNate Graham
Summary: Split out from D23757 Reviewers: #dolphin, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23945
2019-09-14Fix unused variable warningElvis Angelaccio
Should have been removed by 60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 GIT_SILENT
2019-09-10Add Reset Zoom Level action inside View menuNate Graham
Summary: FEATURE: 409591 FIXED-IN: 19.12.0 Test Plan: {F7096397} Reviewers: elvisangelaccio, shubham, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: broulik, cfeck, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D22444
2019-09-09Merge branch 'Applications/19.08'Nate Graham
2019-09-09Fix ascending/descending choosers getting unchecked when re-selecting the ↵Nate Graham
same sort order Summary: When you select the same sort order that's already selected, the currently-checked sort order description (the human-readable ascending/descending items) gets unchecked in `slotSortTriggered()` yet the ascending/descending items items only get checked in `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets checked again. This patch fixes the problem by not unchecking them in the first place. BUG: 411223 FIXED-IN: 19.08.2 Test Plan: 1. Right-click > Sort By > Click the currently-selected sort order 2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: broulik, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23412
2019-09-04Use better-named visible and hidden iconsNate Graham
2019-08-14Correct translation context for zoom out action's what's this textNate Graham
2019-08-13Remove redundant codeAntonio Prcela
Summary: Remove redundant negation and the AND check. OR is enough. Reviewers: meven, elvisangelaccio Reviewed By: meven, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23129
2019-07-29Fix minor typo (thanks to Iñigo Salvador Azurmendi)Yuri Chornoivan
2019-07-04Use more human-readable sort order descriptionsNicolas Fella
Summary: Anecdotal evidence shows that ascending/descending regularly takes people longer to process than necessary. This patch implements more human-friendly sort order descriptions, in particular: A-Z/Z-A for text Newest first/oldest-first for time Lowest first/highest first for rating smallest first/largest first for sizes If there is no string for a particular role defined it will fall back to Ascending/Descending. I'm aware that not every language uses A-Z. In this case the translator can pick any string that represents the concept of text sorting Test Plan: Sort view in various ways Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22006
2019-06-23Add "What's This?" to nearly everything in the main windowFelix Ernst
Summary: This commit adds "What's This?" help to nearly everything in the Dolphin main window (panels, views, buttons, ...). It adds the "?" to the title bar so this help can easily be called. For links in those help texts to work the WhatsThisClickedEvents are handled in the main window class. This doesn't work for menus because events from them aren't forwarded to the main window for some reason so EventFilters are installed for the Control button menus. Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter can be installed in the menubar. Therefore help texts without links are provided for the menubar. Test Plan: Check if the event handling might make any problems. Check for any big mistakes in the help messages. Reviewers: #dolphin, elvisangelaccio Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20471
2019-05-05Get rid of ugly static_cast usages in connect() callsElvis Angelaccio
2019-02-24Give the "Sort by" menu an appropriate iconNate Graham
2018-10-24[DolphinViewActionHandler] Rename createDirectory signalElvis Angelaccio
Signals should be named after an event that happened.
2018-04-13Convert hard coded shortcuts to standard keysRoman Inflianskas
Test Plan: Check all changed shortcuts on all platforms. Reviewers: #dolphin, rizzitello, elvisangelaccio Reviewed By: #dolphin, rizzitello, elvisangelaccio Subscribers: anthonyfieroni, ngraham, elvisangelaccio, rizzitello, #dolphin Differential Revision: https://phabricator.kde.org/D11048
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Modernize the syntax of shortcutsRoman Inflianskas
Reviewers: #dolphin, markg Reviewed By: markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10986
2018-02-18Also use standard keyboard shortcut for "show/hide hidden files"Nathaniel Graham
Summary: Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained. FEATURE: 390527 FIXED-IN: KDE Applications 17.12.3 Test Plan: - Ctrl+H now shows and hides hidden files - Alt+. still works to do the same - F8 still works to do the same - Toolbar button still changes state appropriately when any of the three shortcuts are used Reviewers: #dolphin, elvisangelaccio Reviewed By: elvisangelaccio Subscribers: emateli, elvisangelaccio Differential Revision: https://phabricator.kde.org/D10558
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-10-16Make sure we always have the Del shortcutElvis Angelaccio
Same fix as in D7655, but this time for the MoveToTrash standard action. Differential Revision: https://phabricator.kde.org/D7860
2017-09-17Merge branch 'Applications/17.08'Elvis Angelaccio
2017-09-17Make sure we always have Shift+Del as shortcutElvis Angelaccio
After commit 68bb0ec22a the shortcut for the Delete action is not necessarily Shift+Del, but whatever the user set in System Setting. However DolphinRemoveAction assumes/hardcodes Shift+Del, so we should always make sure we have this shortcut around, for consistency. We just need to add it (if necessary) to the list of shortcuts of the action. However: * for the actual Delete action, we need to append it (if we'd prepend it, it would override a custom primary shortcut in the 'Configure Shortcuts' dialog). * for DolphinRemoveAction, we need to prepend it in order to have Shift+Del (rather than the custom primary shortcut) in the context menu. Differential Revision: https://phabricator.kde.org/D7655
2017-08-24Port to new KStandardAction slot syntaxElvis Angelaccio
For more compile-time safety.
2017-08-09Port to KStandardAction::RenameFileElvis Angelaccio
It was introduced in kconfig(widgets) 5.25. Using the standard action results in less code and no need to hardcode the F2 shortcut. Differential Revision: https://phabricator.kde.org/D6777
2017-07-27Port to KStandardAction::MoveToTrashElvis Angelaccio
It was introduced in kconfig(widgets) 5.25. Using the standard action results in less code and no need to hardcode the Del shortcut. Test Plan: - Change shortcut in System Settings -> Shortcuts -> Standard Shortcuts - Make sure the new shortcut is used by dolphin. Differential Revision: https://phabricator.kde.org/D6778
2017-03-13Port to KStandardAction::DeleteFileElvis Angelaccio
Summary: It was introduced in kconfig 5.25 and it properly handles the shift+del shortcut (together with kxmlgui >= 5.30). This allows us to drop the custom delete shortcut as well as the shift+del workaround in DolphinMainWindow. Test Plan: Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog. Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D5010
2017-01-14Don't overwrite custom icons for the show_hidden_files actionElvis Angelaccio
BUG: 374508 FIXED-IN: 16.12.2 REVIEW: 129789
2017-01-02Properly disable create_dir action in TrashElvis Angelaccio
`isFolderWritable` is set in DolphinView::updateWritableState() according to KFileItemListProperties::supportsWriting(). However, `writing=true` does not imply `makedir=true`, in an ioslave's .protocol file. An example is the trash protocol. So we need to enable the `create_dir` action only if the protocol is actually able to create folders. CCBUG: 332463 REVIEW: 129712
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2016-01-12Adding icon for hidden filesRoman Gilg
REVIEW: 125094
2015-02-24Replace kDebug/kWarning by categorized logging (org.kde.dolphin)Emmanuel Pescosta
2014-12-25Remove unused libkonq includesDavid Faure
2014-11-10make use of initializer listsEmmanuel Pescosta
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-10Clean includes + port to QMenuMontel Laurent
2014-09-14simple setShortcuts => setDefaultShortcuts porting, doneChristoph Cullmann
2014-09-14simple setShortcuts => setDefaultShortcuts portingChristoph Cullmann
2014-09-12Ported KIcon to QIconEmmanuel Pescosta
REVIEW: 120159
2014-07-31Clean up KAction leftovers.Arnold Dumas
2014-06-27Fix build.Christophe Giboudeaux
2014-06-20kde-baseapps frameworks dolphin with snapshot frameworks branch ↵Scarlett Clark
baloo/baloo-widgets path fixes.
2014-05-05dolphin: convert views/ to qt5 signal/slot syntaxAlex Richardson
Removed arguments from DolphinViewActionHandler::slotTrashActivated since they were unused and made the connection fail. Also fixed a bad connection in dolphinview.cpp, there is no signal KFileItemModel::loadingCompleted
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2014-02-06Port Dolphin to BalooVishesh Handa
Nepomuk is being replaced with Baloo
2013-12-29Disable the "Create folder" action in read-only directoriesFrank Reininghaus
The action can be triggered, e.g., by pressing F10. BUG: 294054 FIXED-IN: 4.12.1 REVIEW: 114560
generated by cgit v1.3 (git 2.53.0) at 2026-04-19 01:50:15 +0000