┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views/dolphinviewactionhandler.cpp
AgeCommit message (Collapse)Author
2023-02-06Selects next item in list after delete/trash actionsSerg Podtynnyi
BUG: 419914 BUG: 181214
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2022-10-12Remove unused includesLaurent Montel
2022-08-14Improve naming consistency and leave mode on EscapeFelix Ernst
2022-08-14Improve code qualityFelix Ernst
2022-08-14Better separation of classesFelix Ernst
Make obvious when actions trigger selection mode.
2022-08-14Keep working towards a reviewable stateFelix Ernst
- Various code improvements - Smoother animations - The bottom bar in General Mode only becomes visible if items are currently selected - Removed the selection mode action from the default toolbar since it can already be toggled in various ways - More documentation - Some cleaning
2022-08-14Add Selection ModeFelix Ernst
The selection mode action is a checkable toggle action named "Select Files and Folders" which has "Space" as the default shortcut. In selection mode a bottom bar with contextual actions is shown. These should mostly mirror the actions which are available through the right-click context menu aka DolphinContextMenu. Resizing of the window might make a overflow button appear in the bottom selection mode bar. This commit makes press and hold in the view activate selection mode. This behaviour is not triggered if the press and hold is used to either start a rubberband selection or a drag operation within a short time. The length of the short timeframe is defined by a QStyleHint. This is currently not implemented in touch because I can't test it. Mix the selection mode bars' background colors using a nice combination of colors from the current color scheme BUG: 427202
2022-06-15Use cmakedefine01Ahmad Samir
This way we get a build time warning if the var isn't defined at all, e.g. a missing check_include_files() CMake call.
2022-04-26Add the ability to sort by file extensionEugene Popov
Currently, Dolphin doesn't have the ability to sort by file extension (sorting by type means that files will be sorted by mimetype but not by extension). This MR fixes this shortcoming. BUG: 429579
2022-03-23Allow for more explicit button labelsFelix Ernst
This commit allows us to very explicitly refer to any set of items in text. This way buttons don't need to be labeled generically like "Permanently Delete" but can be enriched to be labeled "Permanently Delete "FileName"" or "Copy 7 Selected Folders" or "Copy 6 Files" or "Rename "file1", "file2", "file3", "file4" and "folder5"". This commit tries to save translators a lot of work by using a translation puzzle. This might be problematic for some languages. The alternative on the other hand would mean that any label which wants to be explicit would need to have over 10 translations just for one label which seems quite bad as well. A fallback is to be implemented for languages that can't really accommodate for any specific word puzzle. This is explained in the documentation.
2021-12-13Drop now unneeded QOverload statementsAlexander Lohnau
By defining the KF_DISABLE_DEPRECATED_BEFORE_AND_AT and QT_DISABLE_DEPRECATED_BEFOREvalues, the deprecated overloads are hidden. This way we only have the un-deprecated one visible.
2021-11-29Use new "edit-copy-path" icon for "Copy Location" menu itemNate Graham
This is safe to change without a fallback icon explicitly specified because if it doesn't exist in the active icon theme, it will fall back to edit-copy which is a standard FreeDesktop icon name present in every icon theme ever. CCBUG: 423937
2021-08-29Revert "Revert "Configurable Show hidden files and folders last toggle""Elvis Angelaccio
This reverts commit bb67def173f31819bb9a696627f9af71c7037dcd.
2021-08-06Revert "Configurable Show hidden files and folders last toggle"Heiko Becker
This reverts commit 50149d6abb8a0a978db3c6afb5238bc42a4a89c8. It breaks the string freeze and I don't think it can count as a bug fix, so it breaks the feature freeze, too. CCMAIL: [email protected]
2021-08-05Configurable Show hidden files and folders last toggleGaston Haro
CCBUG: 241227 Revision: https://phabricator.kde.org/D29115
2021-07-04Port to new KActionMenu popup mode APIDavid Hurka
Use KActionMenu and KToolBarPopupAction::setPopupMode() methods instead of setDelayed() and setStickyMenu(). Are available since KF 5.77 and KF 5.78 respectively, which is already required by Dolphin.
2021-07-04Drop unused listElvis Angelaccio
Spotted by clazy. GIT_SILENT
2021-05-13Re-arrange the contents of the hamburger menuFelix Ernst
To improve usability, the entries in the hamburger menu are changed. Maybe the biggest fault of the previous menu contents were that there were too many actions. The new menu contents are composed of all the actions which are necessary to use Dolphin and those which are very useful and should be of interest for most users. Some menu contents change depending on the state of the application. We can be more bold in only showing what really seems necessary because this commit activates the special sub-menu of KHamburgerMenu that helps users discover all further features of Dolphin. The hamburger menu is from now on also added to the context menus in the view when both the menu bar and toolbar are hidden. This allows users to hide both of them and still use all features of Dolphin.
2021-02-09Add missing includesNicolas Fella
2021-01-16Merge branch 'release/20.12'Elvis Angelaccio
2021-01-16Change copy location shortcut in dolphin so as to not conflict with Konsole ↵The Imp
panel BUG: 426461 FIXED-IN: 20.12.2
2020-12-09operator+/- is disabled for QFlags in qt6Laurent Montel
2020-11-22Remove unneeded version checkAlexander Lohnau
2020-11-17Add missing kconfig_version.h includeElvis Angelaccio
This should have been part of edced8460b.
2020-11-17Correct indentation and whitespace in prior commitNate Graham
2020-11-17Allow folder creation on desktop via F10 shortcutDomenico Panella
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-10-23Compile without foreachAlexander Lohnau
2020-10-15Port away from QList::toSet()Elvis Angelaccio
The QSet range constructor requires Qt 5.14. In `DolphinView::slotHeaderContextMenuRequested()` the conversion from QList to QSet was pointless, so we just use a QList now.
2020-09-22Make "Show hidden files" action follow HIGNate Graham
The action is a toggle action, for which the HIG prescribes that the text should describe the action's checked state, and neither the text nor the icon should change when the action is checked. Other toggle actions in Dolphin follow these rules, but this one does not. This commit makes the action follow those rules.
2020-08-26Text style fixesNikita Churaev
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-06-29## SummaryYann Holme-Nielsen
* Adds a "Copy location" item, after the "Copy" Context item and Edit Menu, which will attempt to copy the path of the fist item into clipboard. ## Reasoning Most File Managers have this option through one or another way. Also using the default Copy option often results in different behaviour depending on the target software, Konsole will take the path. Other Programs will use the URI. Which ultimately could lead to non optimal User Experience. ## Notes * Should the target file **not** be on a local hard drive, this fallback to using the remote URL, feedback is wanted on that matter. FEATURE: 407004
2020-04-20Use new "Show/Hide Hidden Files" standard shortcutNate Graham
Summary: Note that we lose the F8 shortcut since the KStandardShortcut added in XXXX can only accommodate toew default shortcuts, and I thought Ctrl+H and Alt+. were the more important ones. Hopefully that's not too high a price to pay. Depends on D28802 Test Plan: - Apply D28802 to kconfig - Apply this patch to Dolphin, compile, and launch Dolphin - Hit Ctrl+H or Alt+. and see that hidden files are shown or hidden as approproiate Reviewers: #dolphin, dfaure, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28804
2020-03-15Add Duplicate featureNathaniel Graham
Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any. Test Plan: {F5201386} {F5201393} Test cases: - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out - Try to duplicate anything on a read-only local volume: **PASS**: menu item is grayed out - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected - Duplicate single local directory on R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected - Try to undo a successful duplication: **PASS**: operation is undone This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :) Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D8208
2019-12-15Don't overload the word "Properties" to mean multiple thingsNate Graham
Summary: Generally "Properties" refers to information about a selected file. However Dolphin also uses the word "Properties" in the phrase "View Properties", which refers to the display style of the view. Since "properties" is a fairly esoteric and technical term to most users, it would probably be wise to avoid using it in multiple contexts. Accordingly, this patch changes "view properties" to "view display style". Test Plan: Look at the settings window, hamburger menu, view menu, and docbook Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio Subscribers: ndavis, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D25987
2019-11-09Remove unnecessary semicolons after Q_UNUSEDElvis Angelaccio
GIT_SILENT
2019-09-14Improve icons and text for some actionsNate Graham
Summary: Split out from D23757 Reviewers: #dolphin, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23945
2019-09-14Fix unused variable warningElvis Angelaccio
Should have been removed by 60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 GIT_SILENT
2019-09-10Add Reset Zoom Level action inside View menuNate Graham
Summary: FEATURE: 409591 FIXED-IN: 19.12.0 Test Plan: {F7096397} Reviewers: elvisangelaccio, shubham, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: broulik, cfeck, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D22444
2019-09-09Merge branch 'Applications/19.08'Nate Graham
2019-09-09Fix ascending/descending choosers getting unchecked when re-selecting the ↵Nate Graham
same sort order Summary: When you select the same sort order that's already selected, the currently-checked sort order description (the human-readable ascending/descending items) gets unchecked in `slotSortTriggered()` yet the ascending/descending items items only get checked in `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets checked again. This patch fixes the problem by not unchecking them in the first place. BUG: 411223 FIXED-IN: 19.08.2 Test Plan: 1. Right-click > Sort By > Click the currently-selected sort order 2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: broulik, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23412
2019-09-04Use better-named visible and hidden iconsNate Graham
2019-08-14Correct translation context for zoom out action's what's this textNate Graham
2019-08-13Remove redundant codeAntonio Prcela
Summary: Remove redundant negation and the AND check. OR is enough. Reviewers: meven, elvisangelaccio Reviewed By: meven, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23129
2019-07-29Fix minor typo (thanks to Iñigo Salvador Azurmendi)Yuri Chornoivan
2019-07-04Use more human-readable sort order descriptionsNicolas Fella
Summary: Anecdotal evidence shows that ascending/descending regularly takes people longer to process than necessary. This patch implements more human-friendly sort order descriptions, in particular: A-Z/Z-A for text Newest first/oldest-first for time Lowest first/highest first for rating smallest first/largest first for sizes If there is no string for a particular role defined it will fall back to Ascending/Descending. I'm aware that not every language uses A-Z. In this case the translator can pick any string that represents the concept of text sorting Test Plan: Sort view in various ways Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22006
2019-06-23Add "What's This?" to nearly everything in the main windowFelix Ernst
Summary: This commit adds "What's This?" help to nearly everything in the Dolphin main window (panels, views, buttons, ...). It adds the "?" to the title bar so this help can easily be called. For links in those help texts to work the WhatsThisClickedEvents are handled in the main window class. This doesn't work for menus because events from them aren't forwarded to the main window for some reason so EventFilters are installed for the Control button menus. Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter can be installed in the menubar. Therefore help texts without links are provided for the menubar. Test Plan: Check if the event handling might make any problems. Check for any big mistakes in the help messages. Reviewers: #dolphin, elvisangelaccio Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20471
2019-05-05Get rid of ugly static_cast usages in connect() callsElvis Angelaccio
generated by cgit v1.3 (git 2.53.0) at 2026-04-19 21:05:45 +0000