┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views/renamedialog.cpp
AgeCommit message (Collapse)Author
2020-01-11"Use newly-upstreamed rename dialog from KIO""Nate Graham
This reverts commit 41105103b063c2e538bf0071e54fd429a841238b. KIO's version was just bumped to 5.67, so this can land now without breaking the CI.
2020-01-06Revert "Use newly-upstreamed rename dialog from KIO"Nate Graham
This reverts commit bae6620f22d29f8e42e38f4dff3df3e44b3f639a. Frameworks 5.67 doesn't exist yet; this needs to wait another month.
2020-01-06Use newly-upstreamed rename dialog from KIONate Graham
Summary: With the rename dialog upstreamed in D17595, we can use it from there. This will require the KF5 dep to be bumped to 5.67, which should be feasible given that we're at the very beginning of a new Applications cycle. Depends on D17595 Test Plan: 1. Dolphin Settings > uncheck "rename inline" 2. Rename one or more files. Observe that it still works Tests still pass. Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: elvisangelaccio, meven Subscribers: meven, broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17597
2019-09-08GIT_SILENT: minor qstring optimizationLaurent Montel
2019-02-27remove deprecated methodsLaurent Montel
2018-06-05Fix scrolling to renamed file when using the rename dialogElvis Angelaccio
Summary: The `RenameDialog::slotResult()` slot is currently never called because the dialog is deleted first, due to the usage of the `WA_DeleteOnClose` attribute. This breaks the scroll-to-renamed-file feature when the inline renaming is disabled. Instead of deleting the dialog on close, we can use `deleteLater()` when we are sure the dialog has actually finished its job, which is when the KIO move job emits the `result` signal. Test Plan: - Disable inline renaming - Rename a file so that it goes out of the view - Check whether the view scrolls to the renamed file. Reviewers: #dolphin, emateli Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13304
2018-04-05[RenameDialog] Fix crash when renaming single itemsElvis Angelaccio
Summary: `m_spinBox` is initialized only when renaming multiple items. This commit restores the single-item rename logic which was wrongly removed by commit c5eb4e31161ccf422. BUG: 392743 FIXED-IN: 18.03.90 Test Plan: Disable inline renaming and try to rename single or multiple items (and also to undo the jobs). Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D11972
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Modernize the syntax of shortcutsRoman Inflianskas
Reviewers: #dolphin, markg Reviewed By: markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10986
2018-01-27Use BatchRenameJob to rename multiple files in DolphinChinmoy Ranjan Pradhan
Summary: Use KIO::BatchRenameJob in Dolphin::RenameDialog to rename multiple files. With this viewing progress of rename operation and undo is possible. See D9103 and D9107. Reviewers: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, broulik Differential Revision: https://phabricator.kde.org/D9836
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-09-17Keep renamed file(s) in viewEmirald Mateli
When renaming a file, if its new name causes it to scroll out of view, Dolphin will not scroll to the location of the new file. This patch aims to address that. This affects all view modes. CCBUG: 354330 Test Plan: 1. Have many files in a directory (or several files, just zoom in a lot) 2. Rename a file so that it will move out of view Differential Revision: https://phabricator.kde.org/D6312
2017-01-31Merge branch 'Applications/16.12'Kai Uwe Broulik
2017-01-31Hide progress info for rename jobs in rename dialogKai Uwe Broulik
When mass-renaming files, you could end up with a a gazillion notifications of a finished move job. This fixes this. Ideally we would have one job which had the rename jobs as subjobs to still get progress info for the overall task. Differential Revision: https://phabricator.kde.org/D4372
2017-01-18Port away from deprecated KIO::Job::ui()Elvis Angelaccio
It's equivalent to KJob::uiDelegate() from kcoreaddons.
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-09-07Rename dialog: Set focus to input text box on dialog show event.Emmanuel Pescosta
BUG: 351708 FIXED-IN: 15.08.1 REVIEW: 125078
2015-02-26Port away from KDELibs4Support (we only use KDELibs4Support when baloo isn't ↵Emmanuel Pescosta
present, because KFileMetaDataWidget is in KDELibs4Support) Reviewed-By: Vishesh Handa
2015-02-06kdelibs4support--Montel Laurent
2014-11-10KIntSpinBox to QSpinBoxEmmanuel Pescosta
2014-11-10KLineEdit to QLineEditEmmanuel Pescosta
2014-11-10make use of initializer listsEmmanuel Pescosta
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-15Port to QDialogMontel Laurent
2014-10-07kdelibs4support--Montel Laurent
2014-09-22Port away from KonqOperations::renameDavid Faure
2014-09-04extract method renameItem, factorizes the common codeDavid Faure
2014-07-16Use xi18n when text has markupMontel Laurent
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-13Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Since the master branch had never been merged into frameworks since the creation of the frameworks branch, I had to fix a couple of merge conflicts and make another change in order to make it build - I hope I did not get anything wrong. We should probably merge master into frameworks on a regular basis from now on. CCMAIL:[email protected] Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/search/dolphinfacetswidget.cpp dolphin/src/statusbar/dolphinstatusbar.cpp dolphin/src/views/dolphinview.cpp
2014-05-05dolphin: convert views/ to qt5 signal/slot syntaxAlex Richardson
Removed arguments from DolphinViewActionHandler::slotTrashActivated since they were unused and made the connection fail. Also fixed a bad connection in dolphinview.cpp, there is no signal KFileItemModel::loadingCompleted
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2014-03-05Remove some unused functionsFrank Reininghaus
REVIEW: 116562
2013-06-22Enable KIO error reporting when renaming with the dialogFrank Reininghaus
The problem was that the KonqOperations object did not have the right parent. BUG: 299646 FIXED-IN: 4.11.0 REVIEW: 111111
2013-06-20Allow renaming multiple files without number if extensions are differentFrank Reininghaus
Normally, we only allow renaming multiple files if the new file name contains a contiguous sequence of '#' placeholders, which are then replaced by numbers. However, if all extensions are different, we can also rename the files without such a placeholder because the original extension is preserved when renaming. This had been possible some time ago already. That this "accidental feature" was lost was a side effect of the fix for bug 318942. BUG: 321234 FIXED-IN: 4.10.5 REVIEW: 111079
2013-05-02Rename multiple files: Determine correctly if the name pattern is validFrank Reininghaus
The "Rename" button in the dialog should be enabled if and only if the "new name" pattern is valid. This is the case if the pattern contains exactly one sequence of '#', which will be replaced by digits. This patch fixes the problem that (a) A pattern that contains a single '#' is not considered valid, and (b) A pattern without any '#' at all is not recognized as invalid. BUG: 318942 FIXED-IN: 4.10.3 REVIEW: 110223
2013-01-09Show the file name as plain text in the rename dialogEmmanuel Pescosta
BUG: 312812 BUG: 262464 FIXED-IN: 4.10 REVIEW: 108291
2012-12-17Fix Bug 287829 - inline rename multiple files does not honourEmmanuel Pescosta
sort order BUG: 287829 FIXED-IN: 4.9.5 REVIEW: 107718
2012-07-20Fix bug 303375 - Dots in directory names treated as file extension.David Faure
Patch by Emmanuel Pescosta <[email protected]> BUG: 303375 REVIEW: 105575 FIXED-IN: 4.9.0
2012-04-10Add some missing includes.Stephen Kelly
These are needed in Qt5/KF5.
2011-12-15RenameDialog: Don't disable the OK-button if nothing has been changedPeter Penz
This prevents using the RETURN-key when accidently opening the renaming dialog. Thanks to Thomas Murach for pointing this out and providing the patch! REVIEW: 103414
2011-09-01Preserve extensions when renaming multiple filesPeter Penz
Thanks to Chiraq Anand for the patch! The commit is based on the patch at https://git.reviewboard.kde.org/r/102495/ with some minor modifications. REVIEW: 102495
2011-08-15Allow to adjust start-index when renaming a various number of itemsPeter Penz
Review: http://git.reviewboard.kde.org/r/102328/ Thanks to Chirag Anand for the patch! CCMAIL: [email protected]
2011-07-30Merged very early alpha-version of Dolphin 2.0Peter Penz
Dolphin 2.0 will get a new view-engine with the following improvements: - Better performance - Animated transitions - No clipped filenames due to dynamic item-sizes - Grouping support for all view-modes - Non-rectangular selection areas - Simplified code for better maintenance More details will be provided in a blog-entry during the next days. Please note that the code is in a very early alpha-stage and although the most tricky parts have been implemented already very basic things like drag and drop or selections have not been pushed yet. Those things are rather trivial to implement but this still will take some time.
2011-07-03Squeeze the filename shown in the rename dialog when it is too longDawit Alemayehu
and show the full name in a tool tip instead.
2011-05-31Improves 79ccd0202d106a9c16b79a20cd79831a60dc5393 by allowing "/" in file names.Matthias Fuchs
Though here "/" is not the ascii char '/' but the "unicode fraction slash" one, thus it is not taken as directory command. CCBUG:211751 REVIEW:101454
2011-05-28Disallow renaming to names containing '/', names being equal to "." or "..".Matthias Fuchs
BUG:211751 REVIEW:101454
2011-04-16When renaming one item don't replace # by numbersPeter Penz
BUG: 271094 FIXED-IN: 4.7.0