| Age | Commit message (Collapse) | Author |
|
This reverts commit 41105103b063c2e538bf0071e54fd429a841238b.
KIO's version was just bumped to 5.67, so this can land now without
breaking the CI.
|
|
This reverts commit bae6620f22d29f8e42e38f4dff3df3e44b3f639a.
Frameworks 5.67 doesn't exist yet; this needs to wait another month.
|
|
Summary:
With the rename dialog upstreamed in D17595, we can use it from there.
This will require the KF5 dep to be bumped to 5.67, which should be feasible given that we're at the very beginning of a new Applications cycle.
Depends on D17595
Test Plan:
1. Dolphin Settings > uncheck "rename inline"
2. Rename one or more files. Observe that it still works
Tests still pass.
Reviewers: #dolphin, elvisangelaccio, meven
Reviewed By: elvisangelaccio, meven
Subscribers: meven, broulik, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D17597
|
|
Summary:
The `RenameDialog::slotResult()` slot is currently never called because
the dialog is deleted first, due to the usage of the `WA_DeleteOnClose`
attribute. This breaks the scroll-to-renamed-file feature when the
inline renaming is disabled.
Instead of deleting the dialog on close, we can use `deleteLater()` when
we are sure the dialog has actually finished its job, which is when the
KIO move job emits the `result` signal.
Test Plan:
- Disable inline renaming
- Rename a file so that it goes out of the view
- Check whether the view scrolls to the renamed file.
Reviewers: #dolphin, emateli
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D13304
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Summary:
Use KIO::BatchRenameJob in Dolphin::RenameDialog to rename multiple files.
With this viewing progress of rename operation and undo is possible.
See D9103 and D9107.
Reviewers: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, ngraham, broulik
Differential Revision: https://phabricator.kde.org/D9836
|
|
Also use override instead of Q_DECL_OVERRIDE
|
|
When renaming a file, if its new name causes it to scroll out of view,
Dolphin will not scroll to the location of the new file.
This patch aims to address that. This affects all view modes.
CCBUG: 354330
Test Plan:
1. Have many files in a directory (or several files, just zoom in a lot)
2. Rename a file so that it will move out of view
Differential Revision: https://phabricator.kde.org/D6312
|
|
BUG: 351708
FIXED-IN: 15.08.1
REVIEW: 125078
|
|
the deprecated KVersionControlPlugin interface from konqlib
REVIEW: 122687
|
|
|
|
|
|
|
|
|
|
Normally, we only allow renaming multiple files if the new file name
contains a contiguous sequence of '#' placeholders, which are then
replaced by numbers.
However, if all extensions are different, we can also rename the files
without such a placeholder because the original extension is preserved
when renaming.
This had been possible some time ago already. That this "accidental
feature" was lost was a side effect of the fix for bug 318942.
BUG: 321234
FIXED-IN: 4.10.5
REVIEW: 111079
|
|
Review: http://git.reviewboard.kde.org/r/102328/
Thanks to Chirag Anand for the patch!
CCMAIL: [email protected]
|
|
|
|
http://reviewboard.kde.org/r/5496 to allow having leading zeros when renaming files: E.g. Using the name "A ###.jpg" results in the filenames "A 001.jpg", "A 002.jpg"... The patch could be simplified a little bit by guaranting only one connective sequence of #'s.
- Move the renaming code into the RenameDialog
CCMAIL: [email protected]
BUG: 226761
FIXED-IN: 4.6.0
svn path=/trunk/KDE/kdebase/apps/; revision=1182776
|
|
Checks for '#' in the case of renaming multiple files.
svn path=/trunk/KDE/kdebase/apps/; revision=1177675
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1154150
|