┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2020-12-19DolphinContextMenu: drop wrong assertElvis Angelaccio
`m_context` can also be `SearchContext` or `TimelineContext`, so this assert has been wrong since 8b0c12a59ccb23f.
2020-12-17Fix crash when device with capacitybar is draggedChris Holland
BUG: 430441
2020-12-16Use setShowOpenOrExecuteDialog(true) with OpenUrlJobAhmad Samir
It makes more sense for a file manager to always ask the user: - whether to execute binaries - whether to open an executable script as text or execute it The openOrExecute dialog from KIOWidgets has a "don't ask again" checkbox, and that setting is also accessible from Dolphin's settings dialog. See the discussion at https://bugs.kde.org/show_bug.cgi?id=429839#c10
2020-12-15Fix access url navigator while creating new tab in filename search viewAnthony Fieroni
BUG: 429628 BUG: 430434 Signed-off-by: Anthony Fieroni <[email protected]>
2020-12-15Fix KIO warning when URL is emptyDavid Faure
2020-12-07servicemenuinstaller: Remove file if it already existsAlexander Lohnau
This is the case when you update an entry.
2020-12-06GIT_SILENT made messages (after extraction)l10n daemon script
2020-12-05Fix PlacesItemModelTest, 2nd tryElvis Angelaccio
This partly reverts 15a5189b1193cc7305ad2c556d67ec79bdb6e38a The KDE CI does not have KDE_FULL_SESSION set, which means that KIO doesn't add the recentlyused:// urls to the model, but defaults to the old timeline:// urls instead. In both cases KIO adds 2 places, so it is safe to always assume that the expected model count is 14.
2020-12-02GIT_SILENT Update Appstream for new releaseChristoph Feck
2020-11-30Re-allow to paste files via context menuMéven Car
BUG: 429762
2020-11-24Allow the openURLJob to run executablesNate Graham
Otherwise, excecutable files like AppImages won't be allowed to launch even if they are correctly marked as executable. BUG: 429603 FIXED-IN: 20.12
2020-11-23Places panel: highlight place only when it is displayedMéven Car
BUG: 156678 FIXED-IN: 20.12
2020-11-23PlacesItemModelTest: consider also Pictures/Music/Videos foldersElvis Angelaccio
See a371e23b2b667bc85c311d04549f3d7348d00af5 in kio.
2020-11-23PlacesItemModelTest: use helper method to increase indexesElvis Angelaccio
Instead of duplicating the logic all over the place.
2020-11-21Select last visited folder when going up/backFelix Ernst
This commit fixes a regression introduced by ad5d3367c7fef4c3c11188a768f21a2ee2b3c025. A lot of connections were changed there and at least one of them was wrong. The connections can be separated into GUI connections and internal ones. This commit makes it so the GUI stuff is connected to m_urlNavigatorConnected and everything else to m_urlNavigator. BUG: 429097
2020-11-21GIT_SILENT made messages (after extraction)l10n daemon script
2020-11-19Re-allow icons that are not theme iconMéven Car
Particularly concerned are .desktop files. See also: 15baa93640bbb49162f26d439e006729ee9c3441 BUG: 429113
2020-11-19Allow having the UrlNavigators below the tab barFelix Ernst
This commit restores the possibility to have the UrlNavigators below the tab bar. This will happen automatically whenever the UrlNavigator is removed from the toolbar. It is also now again possible to have the toolbar on the side. This option is disabled while the toolbar contains the UrlNavigators. This commit makes no changes to the new default which is having the UrlNavigators in the toolbar but makes sure that upgrading users won't be affected.
2020-11-16PlacesPanel: tooltip, use toLocalFile instead of pathMéven Car
To avoid Windows compatiblity issues.
2020-11-15Increment kpartgui versionFelix Ernst
The defaults changed in 37327c9b0aae112c5890703cba1f0157043007e0 but I forgot to also bump the kpartgui version so this commit rectifies that.
2020-11-14Context Menu: Only add paste action to foldersMéven Car
Either the viewport, or the selected folder is used as destination. The paste action is only added when enabled.
2020-11-13Fix navigator alignment for right-to-left localizationsFelix Ernst
2020-11-12Fix qrc iconAlexander Lohnau
Apparently the icon was not null, because the mimetype was known. But there was no icon associated with it and we got an icon which is not null, but has a null pixmap.
2020-11-12Set empty value for packagekit transaction flagsAlexander Lohnau
Otherwise the value would be Trusted Only, which will forbid installing local packages
2020-11-10Places panel: show a tooltip after 500 msMéven Car
BUG: 426455 FIXED-IN: 20.12
2020-11-09Adress the third round of Angelaccio's review commentsFelix Ernst
Additionally remove some redundant code concerning UrlNavigator visuals.
2020-11-09Adress most of the second round of Angelaccio's review commentsFelix Ernst
This commit applies most suggestions which were made on the MR. Most notably the DolphinUrlNavigator class is split up which leads to the creation of a DolphinUrlNavigatorsController class. Additionally some minor coding style and const correctness changes are included. The error value of cached integers is changed from -1 to INT_MIN because situations could come up in which -1 would be a valid value.
2020-11-09Apply Méven Car's suggestionsFelix Ernst
2020-11-09Fix a crash and extract unrelated changesFelix Ernst
The secondary UrlNavigator is now created when and only when: - split view mode is activated for the active tab OR - switching to a tab that has split view already enabled. This fixes a crash that occurs when the setting to always start in split view mode is enabled. An animation for activating split view is also removed from this and moved into a separate MR. Another unrelated name change left over from a previous commit (viewContainers() -> activeViewContainers()) is dropped.
2020-11-09Make UrlNavigators in the toolbar the only optionFelix Ernst
The UrlNavigators will be automatically added to the toolbar. The Sort By action is removed from the default toolbar to make space. Remove all options to have UrlNavigators outside the toolbar and remove those code paths. Make it so the new NavigatorsWidgetAction contains two UrlNavigators when in split view mode. Spacing was also added to align these UrlNavigators with the ViewContainers when enough space is available. Force the toolbar to be either at the top or bottom of the window. Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this in KUrlNavigator in the future. This commit also contains a changes which should be moved to a separate merge requests before this gets merged: - Add an expansion animation when split view is enabled by the user
2020-11-09Add the UrlNavigator to the toolbar automatically if neededFelix Ernst
This commit adds the DolphinUrlNavigatorWidgetAction::addToToolbarAndSave() method which changes the users toolbar configuration to contain an Url Navigator. This way the user doesn't need to do anything manually. Aside from that a bunch of minor fixes like renaming and reordering
2020-11-09Adress the first round of Angelaccio's review commentsFelix Ernst
- Split the viewContainers(bool includeInActive) into two methods without parameters - Prevent users from accidently hiding all Url Navigators by preventing the dangerous action and then displaying a helpful message instead Unrelated to review comments: Remove a useless line of code
2020-11-09trailing whitespacesFelix Ernst
2020-11-09Add an option to use an UrlNavigator in the toolbar insteadFelix Ernst
This commit adds a locationInToolbar KToggleAction to switch between using a location bar to navigate or using a new custom QWidgetAction in the toolbar. A big portion of this MR is refactoring because until now the UrlNavigator was tightly intertwined with the DolphinViewContainer. With this MR an UrlNavigator for controlling a View can be freely connected or disconnected with a single method call. A DolphinUrlNavigator class is created in the process which contains all Dolphin-specific UrlNavigator code which did previously reside in the DolphinViewContainer class. Other application parts that belong to UrlNavigator-management are also moved here.
2020-11-09PlacesItemListWidget: Use Solid to check if device is a network shareMéven Car
2020-11-08Add missing referenceElvis Angelaccio
2020-11-08Iterate over a const copy list of containersIsmael Asensio
This effectively reverts the mutable iterations approach on 2448f88c5f42d7a2040fcf3bcd3c5f2a2f62cd03, and fix crashes and ghost items when using the filter bar BUG: 428374
2020-11-07Do not expose KCMs in application launchersAlexander Lohnau
We still need to build them, because they are also loaded on konqueror.
2020-11-07KDirectoryContentsCounter: fix support of symlinks dirMéven Car
BUG: 428712 FIXED-IN: 20.12
2020-11-05Add support for KUserFeedbackElvis Angelaccio
This commit introduces KUserFeedback in dolphin with some basic data sources and with a settings page to configure the telemetry values. There are also a couple custom data sources as proof of concept: a bunch of settings and the count of available network shares as listed by Solid. The settings page is shown only if the user feedback framework is enabled, but currently in Plasma we don't have a global kill switch to disable it. At the moment we never show an encouragement message. We need to connect to the `Provider::showEncouragementMessage()` signal, but first we should agree to a common way to show a non-annoying message to the users.
2020-11-05Details view: display empty text instead of unknown for sizeless dirsMéven Car
BUG: 420037 BUG: 420040 FIXED-IN: 20.12
2020-11-04Move m_textInfo to fix ctor warning, and document why it's protected.Chris Holland
2020-11-04Use QDeadlineTimer instead of QDateTime.Chris Holland
Use early returns instead of deeply nested if/else.
2020-11-04Cleanup importsChris Holland
2020-11-04Remove wip debuggingChris Holland
2020-11-04Fix freeSpaceInfo cache not being reset.Chris Holland
2020-11-04Use KDE GitLab url instead of the GitHub mirrorChris Holland
2020-11-04Cleanup unused colors. Use const. Use KColorScheme danger.Chris Holland
The draw code is more like the last state of D21312 now.
2020-11-04Refactor capacity by to use async KIO FreeSpaceJob.Chris Holland
Based on this kio filepicker patch: https://github.com/KDE/kio/commit/933887dc334f3498505af7a86d25db7faae91019
2020-11-04Only show capacity bar for devices (has a udi).Chris Holland
generated by cgit v1.3 (git 2.53.0) at 2026-04-27 16:55:36 +0000