┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2020-01-13GIT_SILENT made messages (after extraction)l10n daemon script
2020-01-11Hide tooltip instantly on filter changePiotr Henryk Dabrowski
Summary: Instantly hide tooltip shown over an element when filter bar changes. Currently the tooltip stays even when filtering causes the file under the mouse to change or disappears entirely. The tooltip also continues to cover much of the window - hiding the new filtering results from user. This is an enhancement to D22512 Test Plan: 1. place the mouse pointer over a file to show the tooltip 2. press "/" to activate filter bar 3. type in filter phrase Reviewers: #dolphin, elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26576
2020-01-06Update Appstream for new releaseChristoph Feck
2019-12-21Improve scroll wheel speed by basing it on label height, not icon heightNate Graham
Summary: Dolphin currently scrolls by the height of three items at a time per "step" when using a scroll wheel. Because item height is highly variable, this leads to scroll speed being inconsistent between views, and generally far too fast when using icon view with icons larger than 22px size. This patch makes the size of the scroll step based on the text label rather than the icon size just like D25683, ensuring that the scroll speed does not vary and become super fast when using large icons in particular. It also reverts 90beb4a5e37b887caad1e767046a42dad0af1ab3, which is no longer needed. BUG: 386379 FIXED-IN: 19.12.1 Test Plan: Use a mouse with a scroll wheel and scroll in Dolphin item views with list view, details view, icon view, etc, using different item sizes. Speed should be consistent in all views now, and also feel consistent with other KDE apps. Also try with multiple scale factors to make sure the behavior does not change. No change with high-resolution two-finger touchpad scrolling. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ahiemstra, lots0logs, anthonyfieroni, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19190
2019-12-09Merge branch 'release/19.12' of git://anongit.kde.org/dolphin into release/19.12Antonio Rojas
2019-12-09Fix build with Qt 5.14 RCAntonio Rojas
Add needed Qt includes that are no longer pulled transitively. BUG: 414492 Differential Revision: https://phabricator.kde.org/D25783
2019-12-06Correct invalid homepage URLNate Graham
BUG: 414901 FIXED-IN: 19.12.1
2019-12-05Update Appstream for new releaseChristoph Feck
2019-11-28fix(search): Fix baloo searchString parsingIsmael Asensio
Summary: Fix the parsing of Baloo query `searchString` to represent its parameters properly in the search box: # Baloo terms (`rating`, `modified`) are added to the user search text: {F7575590} # Extra quotes are added to the search text: https://bugs.kde.org/show_bug.cgi?id=412952 This revision supersedes D24422, by making the fixes on the new dolphin query model, instead of directly on the UI. BUG: 412952 FIXED IN: 19.11.90 Test Plan: - `bin/dolphinquerytest` passes without `XFAIL`s - Dolphin search box is not garbled by search terms or quotes Reviewers: elvisangelaccio, bruns, ngraham, #dolphin Reviewed By: elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25260
2019-11-28Force dbus introspection on the Dolphin_1 objectElvis Angelaccio
Summary: QtDBus caches known interfaces when passing a non-empty interface name to the QDbusInterface constructor. This is an issue when calling the FileManager1 methods more than once, because `preferred` could be a valid interface from the cache, but it would later fail to call the `openFiles`/`openDirectories` methods on the main window. By passing an empty interface name, we prevent QtDBus from using the cache so that we always get an invalid interface when calling the FileManager1 methods on a daemonized dolphin process (that doesn't have the Dolphin_1 dbus object). BUG: 414402 FIXED-IN: 19.12.0 Test Plan: 1. dolphin --daemon 2. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" "" 3. Close the dolphin window that was just opened. 4. Start a normal dolphin process 5. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" "" 6. Close again the dolphin window 7. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" "" Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25510
2019-11-24Fix accessibility regression on the Dolphin Control buttonElvis Angelaccio
9cd042a86c removed the text from the Control button without setting an accessibleName property, which is a regression for screen-reader users. This breaks the 19.12 string freeze, but since it's the same string we were translating before 9cd042a86c, hopefully it's not going to be too much of a burden for translators. CCBUG: 414271 CCMAIL: [email protected]
2019-11-23GIT_SILENT remove unused includeDavid Faure
2019-11-17Fix dolphin homepage in the appstream metadataElvis Angelaccio
2019-11-14test(search): Add test case for baloo parsing modelIsmael Asensio
Summary: Adds a new test unit for the model which parses baloo search URLs 14/19 tests are set to `XFAIL` on current implementation, as they will be fixed in a final revision. Supersedes D25135. Depends on: D25257 Test Plan: `bin/dolphinquerytest` Reviewers: elvisangelaccio, bruns, #dolphin Reviewed By: elvisangelaccio, bruns, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25258
2019-11-13fix(search): Allow to set empty typeIsmael Asensio
Summary: This small patch allows to set and empty `type` to the extended options, which will set the `Any Type` option (index 0). It doesn't make any change in current code, since this case is not called, but it helps simplifying follow-up patches. Test Plan: No behavior changes with current code. Calling `setFacetsType(QString())` actually sets the first option (`Any Type`) Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25255
2019-11-13DolphinQuery: drop DOLPHIN_EXPORTElvis Angelaccio
DOLPHIN_EXPORT is only used by classes in the `dolphinprivate` target, while DolphinQuery is part of `dolphinstatic`. This should fix the failing Windows build on the CI.
2019-11-13refactor(search): De-couple baloo URL parsing logic from UIIsmael Asensio
Summary: Extracts the logic that parses `baloosearch:` urls into a new model class. The parser logic itself is kept as is. The search box UI is later updated using the model fields. This refactor has been proposed by @bruns in the review of D24422, as it largely simplifies the unit tests and further expansion/improvements. Test Plan: No behavior changes. Test case is added in the follow-up revision: D25258 Reviewers: #dolphin, elvisangelaccio, bruns Reviewed By: #dolphin, elvisangelaccio, bruns Subscribers: ngraham, bruns, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25257
2019-11-11SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-10Port away from deprecated API in KWindowSystem >= 5.62David Faure
2019-11-10PlacesItemModel: remove redundant set of propertiesElvis Angelaccio
Summary: The text, icon and url properties are already set in `PlacesItem::setBookmark()`, so there is no need to set them here. The `OnlyInApp` property is part of the KBookmark object that we are going to set to the place item, so there is no need to set it here either. Test Plan: - Open both dolphin and the Plasma file dialog in some app - Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog - Check whether the place in dolphin keeps getting updated accordingly Reviewers: #dolphin, meven, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25230
2019-11-09Remove unnecessary semicolons after Q_UNUSEDElvis Angelaccio
GIT_SILENT
2019-11-09Fix clazy writing-to-temporary warningElvis Angelaccio
2019-11-09Fix clazy non-pod-global-static warningElvis Angelaccio
This list of URLs is only used by cleanupBookmarks(), so there is no need to make it global (which is what clazy complains about). While at it, make it also a `const QVector`.
2019-11-09Fix clazy inefficient-qlist-soft warningElvis Angelaccio
2019-11-09[Status Bar] Remove file status Timer, add text update delayMéven Car
Summary: Currently when hovering over a file we have its name, mimetype type and size display in the status bar for 1 second, after which the status of the folder is displayed. This patch removes this timer making the status bar behavior more predictable and user friendly. Instead there is a 50ms delay between when the status bar gets new text to display (for instance mouse hovering or keyboard navigation) and when the status bar displayed text is updated. This is to avoid flickering. FIXED-IN: 19.12 BUG: 399267 Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25218
2019-11-07Make the search box more compactIsmael Asensio
Summary: Reduce the spacing between widgets and remove the content margins on the extended search options to have a more compact and space-saving layout. Currently, some widgets are not even aligned. This will be even more important if we remove the toggle button for 'More Options'. CCBUG: 386754 Test Plan: BEFORE: {F7681182} AFTER: {F7681184} Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25028
2019-11-03Get rid of search "More Options" toggle buttonIsmael Asensio
Summary: With the new compact search filters (type/date/rating) it makes sense to show these options whenever available, and save some horizontal space on the main bar (specially for verbose languages). These options will be hidden nevertheless if the search is non-indexed or Baloo is disabled. For some nicer aesthetics D25029 should be also applied. CCBUG: 386754 Test Plan: Current: {F7681182} After: {F7687380} Along with D25029: {F7687385} Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg Reviewed By: ngraham, #vdg Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25057
2019-10-30GIT_SILENT made messages (after extraction)l10n daemon script
2019-10-29Replace old deleted nepomuk icon with baloo iconNate Graham
2019-10-28Fix minor issues found by EBNYuri Chornoivan
2019-10-28SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-28GIT_SILENT made messages (after extraction)l10n daemon script
2019-10-27New design for extended search optionsIsmael Asensio
Summary: Replace the arrays of radiobuttons in dolphin search box to more simple dropdown boxes. This provides a leaner look, saving a lot user space on the main view and it is more consistent with the 'Search tools' in the most known sites (Google, DuckDuckGo, etc.) There is room for improvement, as `QComboBox` doesn't match perfectly with the tool buttons used avobe, but I think it is an improvement over the current situation. BEFORE: {F7581883} AFTER: {F7580952} Test Plan: Same behavior with different aesthetics Reviewers: elvisangelaccio, #dolphin, #vdg Subscribers: ndavis, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24602
2019-10-27Unmounting busy device doesn't tell who is blockingDavid Hallas
Summary: Unmounting a busy device from the places panel doesn't tell which applications have open files blocking the unmount. Test Plan: Mount a USB stick using Dolphin Open a file from the USB stick Unmount the USB stick using Dolphin Observe the new error message. FEATURE: 189302 Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven Reviewed By: #dolphin, elvisangelaccio, meven Subscribers: meven, davidedmundson, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19989
2019-10-26When the selection is deselected, restart the keyboard search from the beginningMéven Car
Summary: BUG: 411538 FIXED-IN: 19.12 Test Plan: Open a directory with 3 files starting with the same letter. 1. Press this letter key twice 2. The second file is selected 3. Deselect the file with the mouse or using Esc 4. Wait 1 second 5. Press the same key again Before: The third file gets selected After: The first file get selected ctest Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23716
2019-10-21Disable keyboard accelerators for the tabs widgetAlex Miranda
Summary: Now that there are actions for switching to a specific tab with default Alt + <number> shortcuts, automatically assigned keyboard accelerators can result in ambiguous shortcuts when using specific tab names containing numbers. Not adding any accelerators for the tabs widget ensures the default shortcuts work reliably regardless of tab names. Test Plan: - Verify there are no ambiguous shortcuts when browsing folders with names containing only numbers - Verify other keyboard accelerators still work (menu bar, context menu and others) Reviewers: #vdg, #dolphin, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24794
2019-10-21GIT_SILENT made messages (after extraction)l10n daemon script
2019-10-20Avoid emitting twice twice selectionChanged when keyboard changes the ↵Méven Car
selection, fix slotChangeCurrentItem Summary: In KItemListController::slotChangeCurrentItem searchFromNextItem use was bugged : The two branches of `if (searchFromNextItem)` both looked for the next keyboard with indexForKeyboardSearch(text, currentIndex (the first one with just a +1 modulo). But when searchFromNextItem is false, we are supposed to start to look for the next indexKeyboard from the start of the list `0`, not from the `currentIndex` Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24505
2019-10-20Fix a bug where "Add to Places" remains disabledAlex Miranda
Summary: Fix a bug where "Add to Places" doesn't get re-enabled in the context and file menus when nothing is selected after previously selecting a single file that is not a directory or multiple files. Test Plan: Verify the action remains enabled when appropiate Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: meven Subscribers: meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24690
2019-10-20[dolphin/search] Reset search options when neededIsmael Asensio
Summary: Adds a method to reset the options in `facetsWidget` in two cases: when disabled and before parsing a new search URL. Otherwise, controls for a parameter (ex. `rating`) which are not found in the new URL would stay on the old positions, instead of the default "any". See D24422 Test Plan: Controls on `facetsWidget` go back to the default in such two cases. Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24450
2019-10-20[dolphin/search] Fix search behavior when selecting "Your Files"Ismael Asensio
Summary: Fix the search box forgetting the location where the user was previously searching into. To do a search on "All Files" instead of setting the `m_searchPath` to `$HOME`, it checks the button state, so the "From Here" location is not lost. As an added benefit, selecting "Your Files" when in a non-indexed folder will use the baloo search instead of a fully non-indexed search from $HOME. This issue is the last remaining one of the series started with D24422, with the purpose of fixing the searchbox parsing and update. Test Plan: - Toggle between "From Here/Your Files" and navigate between locations - The search box remembers the location and keeps a coherent state {F7575402} Reviewers: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24577
2019-10-13properly enable hi-dpi supportChristoph Cullmann
2019-10-13Hide search extra options when not availableIsmael Asensio
Summary: Hide the search extra options when they are not available, because the current location is not indexed or Baloo is not enabled. The button is disabled and shows a tooltip to provide feedback of why it's not available. Depends on D24478 {F7531893} CCBUG: 396898 FEATURE: 318580 FEATURE: 408680 FIXED-IN: 19.11.80 Test Plan: - `Ctrl-F` on a non-indexed location - `balooctl disable` and `Ctrl-F` on an indexed location On both cases the extra options are not shown, the button is disabled and the reason is shown in the tooltip The user selection is remembered between indexed locations. Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24446
2019-10-13Add actions for switching to a specific tabAlex Miranda
Summary: Add actions to switch to each of the first 9 tabs and another action to switch to the last tab. This feature makes it much easier to quickly switch between tabs just like you normally would be able to when using a web browser or other applications. Reviewers: #vdg, #dolphin, ngraham, elvisangelaccio Reviewed By: #vdg, #dolphin, ngraham Subscribers: meven, ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24353
2019-10-10Refactoring: add shouldClearSearchIfInputTimeReached to ↵Méven Car
KItemListKeyboardSearchManager
2019-10-08[dolphin/search] Add method isIndexEnabled()Ismael Asensio
Summary: Extracts the logic for checking if the current path is indexed to its own method. Test Plan: No behavior changes Reviewers: elvisangelaccio, ngraham, meven Reviewed By: ngraham, meven Subscribers: meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24478
2019-10-07[dolphin/search] Avoid unnecesary reloads on setSearchPathIsmael Asensio
Summary: Check in `setSearchPath()` if the `url` passed is already the `searchPath` This was causing an effect where reloading the same search URL results on buttons `From Here/Everywhere` toggling. See D24422 Test Plan: On your home folder press `Ctrl-F` several times Buttons `From Here/Everywhere` should now not toggle each time Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24449
2019-10-07[dolphin/search] Add missing parsing for type 'Folder'Ismael Asensio
Summary: Add missing parsing for type 'Folder' See D24422 Test Plan: dolphin --new-window 'baloosearch:?json=%7B%22type%22:[%22Folder%22]%7D' - `Folders` is selected in search options Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24448
2019-10-06Merge branch 'Applications/19.08'Elvis Angelaccio
2019-10-06Fix crash when lauching dolphin with a search schemeIsmael Asensio
Summary: Widget objects are initialized in `DolphinSearchBox::init()`, which is called on `QEvent::Polish`, so we must set it visible before calling `fromSearchUrl`. Test Plan: `dolphin --new-window baloosearch://` Reviewers: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24432
generated by cgit v1.3 (git 2.53.0) at 2026-04-25 17:51:22 +0000