| Age | Commit message (Collapse) | Author |
|---|
|
When no device was found or no storage within.
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Sometimes the selection is empty or not updated properly. Better be
safe than sorry and make sure the items are always up to date.
This amends commit db49ac4e
|
|
For this widget.
If a file is being moved due due to external events, an animation may
start, in which case we better cancel the edit.
If we hook this at the animation start instead of checks spread out, we
can't miss this cancellation anymore.
KStandardItemListWidget gets a cancelRoleEditing slot to cleanly cancel
editing and clean up its internal state.
|
|
When switching tabs with split view enabled and the filter bar visible,
a storm of activation calls is triggered and at the end signal/slot
connections for both views is a mess (no listeners, navigation buttons
linked to unfocused view etc.).
Disconnect DolphinTabPage slot when it changes its own state.
BUG: 508554, 512011, 508405, 511076, 503576
|
|
search results
When navigating away from a search result, hiding the search bar unintentionally emitted urlChangeRequested(searchPath). This inserted an extra navigation step into the history, causing the “Back” button to require multiple presses to return to the search results.
Introduce Search::Bar::HideBehavior to allow callers to hide the search bar without triggering a URL change, and use it when the bar is automatically hidden due to non-search navigation.
BUG: 515236
|
|
The search field moves upwards and becomes obscured when pressing navigation keys like the down arrow. This happens because the underlying QScrollArea processes keyboard navigation events, shifting the visible viewport even when scrollbars are completely hidden and disabled.
Move the event filter from the contents container directly to the QScrollArea (m_contentsContainerParent) and its viewport. Update the filter to intercept Qt::Key_Up and Qt::Key_Down events, preventing the scroll area from handling these inputs.
BUG: 510469
|
|
|
|
Prevent a mem-leak detected with asan.
|
|
|
|
Currently, Dolphin's filter bar defaults to plain text, but it actually has a hidden regex functionality too: it tries to auto-detect and switch to a regular expression if characters like '*', '?', or '[' are present in the search string.
This approach has a couple of issues. First, the regex/wildcard functionality is completely hidden from the user. Second, the auto-detection is flawed because those are perfectly valid characters in Linux filenames. If a user tries to filter for a file literally named [draft].txt, the auto-switching kicks in and causes unexpected behavior.
This MR fixes this by making the filtering modes explicit through a ComboBox at the side of the filter bar, with the options 'Plain Text', 'Glob' and 'Regular Expression'. It also adds a button to toggle the case sensitive matching. A visual feedback for when the user is inputting an invalid expression has also been implemented by turning the bar background red and making appear an error symbol.
|
|
Adds ZoomLevel flag to the directory and uses it instead of global settings when globalViewProps is set to false.
CCBUG: 169405
|
|
|
|
Explicitly grabGesture TapAndHoldGesture to be able to ignore them and
thus prevent bubbling the event to the parent widget.
BUG: 431307
|
|
This removes the .desktop suffix to match https://invent.kde.org/utilities/kfind/-/blob/master/src/org.kde.kfind.appdata.xml?ref_type=heads#L3
BUG: 510370
|
|
KCModuleLoader when passed in a parent Widget will add a layout to it.
The internal widget is added to it.
When we don't pass a parentWidget, this layout leaks.
Instead don't add a layout ourselves, let the one in KCModuleLoader do
the work.
Detected by asan.
|
|
|
|
Prevents a mem-leak on exit spotted by -fsanitize/asan.
|
|
BUG: 510829
|
|
BUG: 433937
|
|
So the selection manager can consider the selection has changed.
This makes sense as when editing file name you can only have a single item selected.
BUG: 453262
|
|
Like with leftclick, we should check this for rightclick.
If user has highlightEntireRow enabled and right clicks an
item, the item should be activated.
BUG: 508356
|
|
Certain urls lead to an infinite loop that causes dolphin to halt. Any url that starts with `file:` and the path doesn't have first `/` will lead to this. For example: `file:test` or `file:another/test`. If dolphin somehow saves this state, the program halt right at the start.
Rename the function to make its usage less confusing.
|
|
Limit the width of text labels.
|
|
Revert "!1026"
The behavior change introduced in !1026 significantly alters the new folder creation behavior in Dolphin and has proven controversial among users. It likely requires additional design discussion and iteration to arrive at a solution that works well in all cases.
Until a more robust solution is agreed upon, revert the change and restore the previous behavior.
BUG: 516341
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Align horizontally the form and make sure the label have enough room.
|
|
when trying to open a file as directory we run into a IsFile error and
instead open the parent directory. this is a bit inconvenient when the
user actually wants to open a file. allow them to redirect the request
to the correct API instead. this ensures backwards compatible behavior
but introduces new strings that require localization.
ultimately being able to open files this way is a bit of any-feature
though.
CCBUG: 516830
|
|
we already have xdg-run, we don't need another runner interface ;)
notably if the user disabled the ask-before-execute guard rail from KIO,
they would also implicitly allow other applications to execute any file
by invoking it through dolphin, that would be a bit silly and isn't the
point of the guard rail opt-out.
when detecting a file we now instead open the parent
Should improve
CCBUG: 516830
|
|
settings page
* added link button in Context Menu Settings to Shortcuts for Context Menu Actions as shown below
* removed the text above the search bar, which said "Select which services should be shown in the context menu:" since the check-boxes are clear enough
* instead of "Download New Services" the link to download services now just says "Download Services" for brevity.
{width="602" height="600"}
before:
{width=768 height=600}
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
(cherry picked from commit accfcb097776bab5d6a3c07539de94ba2ff4991d)
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Introduce ServiceMenuShortcutManager, which registers all service menu actions with KActionCollection at startup allowing users to assign keyboard shortcuts in Configure Keyboard Shorcuts. Save/Load of configs happens via KXMLGUI in dolphinui.rc.
Notes:
- Manager initializes before setupGUI() for shortcut restoration
- Execution and validation handled entirely by KFileItemAction in KIO.
BUG: 260266
|
|
|
|
This commit corrects previous attempt of bug fix done in
https://invent.kde.org/frameworks/kio/-/commit/71b2b38b0c4fc4c7820fd95b031413d854d8f8c6?merge_request_iid=2074
which incorrectly recognized drop action from Places View (based only
on missing Qt::MoveAction which had side effects described in BUG 514697)
This time DolphinView indicates that the given dropEvent
comes from Places View so we must avoid potentially destructive
Move-like plugins actions. This is done by setting proper
KIO::DropJobFlags additional flag for KIO::drop().
CCBUG: 509231
CCBUG: 514697
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
We show the error message in our own message widget already.
|
|
Preventing a mem-leak on process leave.
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Avoids the item being considered dirty when *we* changed it.
It is guarded in most places but wasn't done in the pixmap animation stuff
causing the item considered dirty whenever hovering it.
|
