┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2019-06-24Fix minor typosYuri Chornoivan
2019-06-23Add "What's This?" to nearly everything in the main windowFelix Ernst
Summary: This commit adds "What's This?" help to nearly everything in the Dolphin main window (panels, views, buttons, ...). It adds the "?" to the title bar so this help can easily be called. For links in those help texts to work the WhatsThisClickedEvents are handled in the main window class. This doesn't work for menus because events from them aren't forwarded to the main window for some reason so EventFilters are installed for the Control button menus. Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter can be installed in the menubar. Therefore help texts without links are provided for the menubar. Test Plan: Check if the event handling might make any problems. Check for any big mistakes in the help messages. Reviewers: #dolphin, elvisangelaccio Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20471
2019-06-23Allow dolphin to auto-play previewed media file, click on preview to ↵Méven Car
play/pause videos or audio Summary: It is based on D19844. I did my best to avoid glitches hence the amount of code touched. Retry after @pekkah D7539 Moved the setting to the information panel context menu, no more timer Settings screenshot : {F6700220} This would mach the same feature in the open/save dialog (although not equivalent) {F6696456} FEATURE: 378613 FIXED-IN: 19.08.0 GUI: New information panel context menu option Test Plan: Without auto play - in dolphin with the information panel opened, and the auto media play feature is disabled (right on the information panel) - hover over media files - the behavior is the same as before the patch With auto play - in dolphin with the information panel opened, and the auto media play feature is enabled - hover over media files - media is played automatically - hover over another media file, the new media is previewed Use audio or video file as media. Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, broulik, kfm-devel, pekkah Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19782
2019-06-23Fix tests relating to the removal of the Root Place in D15739Méven Car
Summary: See D15739 Test Plan: ctest Reviewers: elvisangelaccio, ngraham Reviewed By: elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21789
2019-06-23Adding option to open externally called folder in a new tabAlexander Saoutkin
Summary: Adds an option to open externally called folder in a new tab. By default this option is enabled Test Plan: If option selected: 1. All valid arguments passed to Dolphin should be opened in tabs of an instance(s) (if it exists). Duplicate tabs just change activation to current tab. If option not selected: 1. All calls to Dolphin result in a new instance being opened This option does not require Dolphin to be restarted to take effect. Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, ngraham Subscribers: broulik, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21736
2019-06-22Open new instance of Dolphin if no URLs are givenAlexander Saoutkin
Summary: BUG: 408387 BUG: 408244 FIXED-IN: 19.08.0 Currently Dolphin only opens a new instance of itself in the following two scenarios: 1. No other Dolphin instances ( D21666 deals with not matching daemonized instances) are currently running. 2. A new instance is explicitly asked for via: `dolphin --new-window` A third scenario is needed to fix this bug: 3. If no URLs are passed in as arguments then open a new instance. This patch adds this third scenario. Test Plan: STEPS TO REPRODUCE 1. Open Dolphin 2. Right-click on Dolphin's Task Manager Entry and click "Start New Instance" 3. A new instance is created. As my system stuff is not built on master I am unable to replicate the bug (and can't confirm whether this fixes it), hence I'll rely on @ngraham to confirm whether this patch fixes the issue. Reviewers: ngraham, elvisangelaccio Reviewed By: ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21691
2019-06-11SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-06-10Do not match daemonized dolphin instancesElvis Angelaccio
Summary: `dolphin --daemon` does not have the `/dolphin/Dolphin_1` dbus path, because it doesn't have any DolphinMainWindow. Checking if the QDBusInterface is valid is not enough, we also need to look for dbus errors. BUG: 408244 Test Plan: 1. Make sure there is a `dolphin --deamon` process around. 2. Start another dolphin process. Reviewers: broulik, ngraham, feverfew Reviewed By: feverfew Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21666
2019-06-08Fix container detachingElvis Angelaccio
2019-06-07Make Bookmarks item work properly as a toolbar itemNate Graham
- Make its menu open on click, not click-and-hold - Give it a proper icon BUG: 408346 FIXED-IN: 19.08.0
2019-06-07[DolphinContextMenu] Restore check for whether place already existsKai Uwe Broulik
Now that we have a places singleton it adds no real overhead. Differential Revision: https://phabricator.kde.org/D21600
2019-06-05Scroll when pressing PageUp/PageDownTranter Madi
Summary: Add `PageUp/PageDown` to the `navigationPressed` variable. Remove the `m_view->firstVisibleIndex()` and `m_view->lastVisibleIndex()` tests because sometimes it does not work correctly. BUG: 407118 Test Plan: Press PageUp/PageDOwn: it scrolls Press Up/DOwn: it always scrolls Reviewers: #dolphin, Zren, cfeck, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21573
2019-06-04Merge branch 'Applications/19.04'Kai Uwe Broulik
2019-06-04[Places Panel] Pass iconName to KFilePlaceEditDialogKai Uwe Broulik
Ensures that editing an entry with a custom icon doesn't have its icon discarded. Differential Revision: https://phabricator.kde.org/D21558
2019-06-03Tighter match own service when trying to find suitable window to open path in.Thomas Posch
Summary: Current implementation matches org.kde.dolphin-.*PID while trying to exclude itself from the list of running instances. With this fix applied only org.kde.dolphin-PID is matched. Test Plan: Open dolphin twice. Observe only one window. Reviewers: feverfew, #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21547
2019-05-30Open externally called files/directories in new tabsAlexander Saoutkin
Summary: FEATURE: 183429 FIXED-IN: 19.08.0 GUI: new cli argument --new-window Externally called files/directories are opened in a a new tab of an instance of Dolphin that already exists. If any of the given URIs are already open in a tab, then those tabs are activated instead of a new tab being opened. If there is no instance then the files/directories are opened in a new window. The newly opened file/directory has its tab activated, and consequently, the window is also activated. When the user clicks "Open In New Window" or "Detach Tab", the files/directories are opened in a new window. Test Plan: [Manual] Before testing, set the default file manager in system settings as the newly built Dolphin executable. One must also include the new dolphin executable in the $PATH, otherwise some functions will attempt to open the system dolphin instead of the new one. Furthermore, running two different versions of Dolphin (in particular, where one does not have this patch included) can result in bugs appearing, in particular, new tabs not opening as old instances will not recognise the DBus commands sent to it. However, I see no reason why a user will have two different versions of Dolphin (apart from people like us :D). Open directories with the help of auxillary programs (i.e. a browser). The files/directories should appear in a new window if an instance does not exist. If an existence already exists, then a new tab should be opened and activated in that instance and the window activated. Use QDBusViewer to open folders/items by calling the ShowFolders/ShowItems methods in org.freedesktop.FileManager1 of the Dolphin instance. When a user chooses to "Open In New Window"/"Detach Tab" then the files/directories should be opened in a new window. Reviewers: #dolphin, elvisangelaccio Subscribers: zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16648
2019-05-30handle maps with multiple or single entries from BalooAlexander Stippich
Summary: Handle maps which may contain multiple entries with the same key. Bumps frameworks to 5.58. Equivalent to D20739. Reviewers: #dolphin, elvisangelaccio, bruns Reviewed By: #dolphin, elvisangelaccio, bruns Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21157
2019-05-25When filter bar is focused, switch to view when tab key is pressedNate Graham
Summary: Various people have requested that the tab key move keyboard focus from the filter bar's text edit field to the main view. It already does this when the Enter and return keys are pressed, but apparently this is not very intuitive and people expect Tab to work too. This patch makes that behavior possible by moving the Lock button to the left of the text edit field, and re-arranging the code so that the filter bar is initialized first. This works because Qt assigns tab ordering by default according to the order of widget construction. So if we simply construct the main view right after the filter bar, then the tab ordering is set up this way automatically. BUG: 403379 BUG: 403356 FIXED-IN: 19.08.0 Test Plan: 1. Activate Filter bar 2. Hit Tab key 3. View has become focused 4. Play around in Dolphin for a while and notice no regressions or crashes Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21177
2019-05-24GIT_SILENT made messages (after extraction)l10n daemon script
2019-05-23GIT_SILENT made messages (after extraction)l10n daemon script
2019-05-22SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-05-20Add Documents shortcut detectionAndrew Crouthamel
Summary: This adds support for Documents detection when included as a default as implemented in D16852. This is a work-in-progress and currently does not succeed. Assistance is welcome. Test Plan: Run ctest within the dolphin build directory. Reviewers: #dolphin Subscribers: elvisangelaccio, kfm-devel, ngraham Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16967
2019-05-20Merge branch 'Applications/19.04'Nate Graham
2019-05-20Elide tab titles left so key information at the end of the string doesn't ↵Nate Graham
get cut off Summary: Tab Titles currently elide right. Generally the more useful information is at the right side of the string--even more so when full paths are being used. BUG: 406569 FIXED-IN: 19.04.2 Test Plan: - No change when tab titles don't get elided - When tabs show the full path and titles are elided, they're now useful: {F6782447} - When tabs don't show the full path and are elided, they're elided on the other side which seems maybe a tiny bit better, but at least no worse: {F6782448} Reviewers: #dolphin, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ndavis, elvisangelaccio, kneckermcknacksack, filipf, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20689
2019-05-15GIT_SILENT made messages (after extraction)l10n daemon script
2019-05-15GIT_SILENT made messages (after extraction)l10n daemon script
2019-05-13Summary: Fixes crash when hiding devicesDavid Hallas
Summary: Fixes crash when hiding devices. The crash is caused by KStandardItem::setDataValue which calls the KStandardItemModel::onItemChanged function, and that function will delete the KStandardItem if the data value being set is the hidden attribute being set to true. To fix this KStandardItem now derives QObject so that we can use deleteLater. Test Plan: Right click a device in the places panel and select hide Right click the places panel and select show hidden Right click the hidden device and select show Right click the same device and select hide BUG: 403064 Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21050
2019-05-13Add Bookmark HandlingDavid Hallas
Summary: Add Bookmark Handling. Adds complete bookmark support as provided by other KDE applications like Konsole and Konqueror. This allows you to bookmark individual folders, create bookmark folders and open them. Test Plan: Go -> Bookmark -> Add Bookmark Go -> Bookmark -> [Open the bookmark you selected] FEATURE: 171366 Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ognarb, meven, loh.tar, cfeck, hein, kfm-devel Tags: #dolphin Maniphest Tasks: T5408 Differential Revision: https://phabricator.kde.org/D19926
2019-05-12Fix stale commentElvis Angelaccio
GIT_SILENT
2019-05-12Fix indentationElvis Angelaccio
GIT_SILENT
2019-05-12[Inline Rename] Move cursor to correct position on pressing Home and EndChinmoy Ranjan Pradhan
Summary: When pressing home or end key on a wrapped file name the cursor should move to beginning or end of the whole file name instead of the last line (which is the default behaviour of any textedit widget). BUG: 363179 Reviewers: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21031
2019-05-08services/test: Fix testAlexander Potashev
Reviewers: #dolphin, elvisangelaccio, sitter Reviewed By: sitter Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21022
2019-05-05Get rid of ugly static_cast usages in connect() callsElvis Angelaccio
2019-05-05[PlacesItemModelTest] Rename variableElvis Angelaccio
This variable is not the expected size of the groups list, but it's the expected index of the 'Remote' group in the model.
2019-05-05Fix formatting in CMakeLists.txtAlexander Potashev
Reviewers: elvisangelaccio Reviewed By: elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21021
2019-05-05Merge branch 'Applications/19.04'Elvis Angelaccio
2019-05-05[PlacesItemModelTest] Ignore user tag placesElvis Angelaccio
Instead of listing the user tags (as tried in D21017), the test should not have access to the user's baloo DB in the first place. To do so, we use a QTemporaryDir as $HOME for the test process and for its ioslave children (by setting KDE_FORK_SLAVES=yes). While at it, drop the no-op removeTestUserData() function.
2019-05-05Merge branch 'Applications/19.04'Elvis Angelaccio
2019-05-05Try again to fix PlacesItemModelTest::testDefaultViewProperties()Elvis Angelaccio
Commit bff373d598c031cb1 was not enough because the model takes into account the global view properties setting (in PlacesItemModel::initializeDefaultViewProperties()). This means we need to disable the setting before init() runs.
2019-05-04Fix create_symlink path to DESTDIR instead of root file systemArfrever Frehtes Taifersar Arahesis
Test Plan: Builds fine again in a sandbox, with the symlink properly installed. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: davidedmundson, elvisangelaccio, kfm-devel, ngraham Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21011
2019-05-04Fix wrong apidoxElvis Angelaccio
There is no KStandardItemView class in dolphin. This apidox has been wrong since the beginning (see commit ae4d11d918938fd9087f2035dac). GIT_SILENT
2019-05-04Merge branch 'Applications/19.04'Elvis Angelaccio
2019-05-04Fix dolphin cannot be added as favourite in GNOMEElvis Angelaccio
The StartupWMClass entry is needed because gnome-shell gets confused by the mismatch between the desktop file basename ('org.kde.dolphin') and the WM_CLASS window property ('dolphin'). BUG: 407198 FIXED-IN: 19.04.1
2019-04-23[InformationPanel] Use the new inline configuration modeStefan Brüns
Summary: The current external configuration dialog has some issues: - its layout is suboptimal, as its initial size is typically to small - it is quite disassociated with the actual widget it configures, properties have a different order, and the property names can be quite abstract without the corresponding value. Doing the visibility selection inline typically avoids the sizing problem, as the containing application (dolphin) is often vertically maximized. The selection becomes more obvious, as the item order is kept, and the values are shown. Depends on D20524 CCBUG: 389571 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20525
2019-04-22Use placeholder for search actionCarl Schwan
Summary: See https://hig.kde.org/style/writing/placeholder.html Screenshot: Old: {F6691712} New: {F6698685} Test Plan: Compile and run Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham Subscribers: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel Tags: #dolphin, #documentation Maniphest Tasks: T10258 Differential Revision: https://phabricator.kde.org/D19770
2019-04-22[InformationPanel] Remove obsolete intermediate wrapper widget/layoutStefan Brüns
The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper. Summary: Depends on D20667 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, elvisangelaccio Reviewed By: #dolphin, #baloo, ngraham, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20668
2019-04-20More coding style fixesElvis Angelaccio
GIT_SILENT
2019-04-20Fix missing update of file name label in information panel without previewStefan Brüns
Summary: The file name label was only updated when the preview was shown, after the function was moved into a conditional section. This is a regression caused by commit 405aa4878f75 ("[InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled"). Test Plan: Hide the preview in dolphin's information panel Hover different files, the name label reflects the hovered file again Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20660
2019-04-20[InformationPanelContent] Fix coding styleElvis Angelaccio
GIT_SILENT
2019-04-18Merge branch 'Applications/19.04'Nate Graham
generated by cgit v1.3 (git 2.53.0) at 2026-04-23 10:59:35 +0000