| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
The mouse events need to modify the keyboard anchor assignments as well,
because selecting an item with a mouse and then navigating with keyboard
wouldn't follow the same selection.
BUG: 508609
|
|
So the new folder is in view.
|
|
When a user selects a custom font via the font dialog, the font mode combobox (showing System Font / Custom Font) was updated to use the selected font.
This caused an unintended visual inconsistency, as configuration UI elements should always be rendered using the system application font, independent of the font chosen for the content view.
Fix this by removing the setFont() call in openFontDialog(), ensuring the combobox remains visually consistent with the rest of the configuration interface.
BUG: 499783
|
|
This MR adds options to keep tab bar always visible and to remove the close button from tabs.
MR !269 cannot be reopened because the branch it is based on is no longer accessible. Per @meven direction, I am opening this new MR.
Note: Defaults to current defaults.
{width=734 height=597}
{width=762 height=580}
Criticisms of previous MR:
* Options should take effect immediately when users apply new settings, rather than requiring restart.
* Done.
* Concern about potential maintenance burden.
* I've been maintaining some version of this patch for ~4-5 years, available via [aur/dolphin-tabopts](https://aur.archlinux.org/packages/dolphin-tabopts) and Chaotic AUR. During that time, only two major rebases were needed. First was what appeared to be automated linting and reformatting. Second was when the preferences system was reorganized.
Had the patch been integrated in the code base prior to those refactors, the first would have required zero maintainer intervention (assuming automated reformatting). The second would have required minimal effort beyond what was needed for the refactor itself.
Every defect I've noticed during that time were also present in the unpatched package.
* There is no demand or desire for this feature.
* Equivalent settings are available in various apps across operating systems and desktop environments, including several KDE apps, such as akregator, kate, konsole (confirmed in 25.12.1).
* The first merge request in this repo !1 was to implement always showing the tab bar.
* Some users have found, created an account, and commented at the previous MR to ask that it be reconsidered.
* Arch opt-in pkgstats shows non-zero count for aur/dolphin-tabopts since early 2023. Max 15 in early 2025. Current 5.
* Chaotic AUR download metrics is 41 (rolling 30-day count).
* Unproductive "discussion" not worth further comment.
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
When holding shift when middle-clicking.
Amends: a25f2cc67cbab7f001c883931a433f1841223a87
CCBUG: 496687
|
|
It turns out that since f6c97d52220be9bd996b71309051e56ff7aa1834 a temp file is created here with each `save()` call for this default config, which is not deleted later. In another place where `defaultProperties()` is called for `m_node`, the file is deleted in the destructor of this class. But it is not deleted here.
So, remove temp file after loading defaultConfig or it will create temp file on each save() operation in /tmp folder.
Also keep the global/.directory file when xattr isn't supported.
BUG: 510500
|
|
Q_CHECK_PTR (other than the name suggests) is intended only to check the
success of memory allocations.
Using it for any pointers instead can be misleading due to the
"Out of memory" log printed in case of hits.
|
|
Previously in cases where user was expanding a folder that has only
images in detailed view, it would suddenly change into dynamic view.
This patch avoids doing any changes to the user workflow if they have
expanded the folder, avoiding surprising behavior.
|
|
Reload the context menu plugins and share the KFileItemActions with the context menu so it stays up-to-date as the user changes the service menu settings.
This uses a KConfigWatcher to trigger settings reload on "kservicemenurc" changes, covering both internal settings changes and external scripts.
Remove the obsolete restart prompt in ContextMenuSettingsPage since changes are now applied instantly.
BUG: 508722
|
|
For ease of access, KXmlGui adds actions in a delayed/split toolbar
button to its own context menu. We have no access to this menu, so
we cannot install our middle-click event handler for the back/forward
action menus.
To address this, we detect the action showing for the first time and
install an event filter on the associated object if we think it's
the menu.
|
|
Currently, Dolphin silently falls back to a non-italic variant because italics are reserved for symbolic links. The new message informs users that their selected style cannot be fully applied to avoid confusion.
BUG: 499784
|
|
It's no longer true that KIO preview would block. It spawns an
asynchronous stat job if it needs to determine the mime type.
|
|
The font selection dialog for custom view fonts was always initialized with
the system default font instead of the previously selected custom font.
This occurred because QFontDialog::getFont() was not passed the current
custom font stored in DolphinFontRequester.
By initializing the dialog with currentFont() (which returns the stored
custom font when in Custom Font mode), users will now see their previous
font selection when reopening the dialog, enabling easier font finetuning.
BUG: 499786
|
|
222c8eb5 has accidentally reverted 4deeb7bc. This re-applies this.
|
|
When a file is deleted using the Delete key, the next item gains focus but loses its selection, which breaks further keyboard deletion.
This patch ensures the next item is explicitly selected after clearing the previous selection.
BUG: 513371
|
|
(cherry picked from commit 31fa6509c29f730a8a1d4fe1c8dbf50a1f1fcf9c)
|
|
|
|
If we have return early because dynamic view is not enabled
or we have Icon View already, then do not try to load view
properties to get 'dynamicViewPassed' property.
Otherwise, for example, it infinitely calls
the ViewProperties::save() method for the /tmp folder,
which generates a bunch of temporary files
(on new user, if dynamic view is not enabled
and Icon View applied by default)
BUG: 508402
|
|
BUG: 513345
|
|
Commit 8d44699f introduced a new session file format, without providing a migration path for the old file format, which led to users losing their session.
Besides adding the migration path, the condition check for future updates is necessary, since we don't provide guarantees for backwards-compatible format changes. In case users downgrade their Dolphin version/immutable distro or they share the Dolphin config file across multiple systems, Dolphin at least won't crash when reading a session file with a newer format.
BUG: 513466
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Using plural here better conveys that every new window will have split view mode enabeled. The original string was introduced in !1103
CCBUG:464696
CCBUG:186185
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Fix the issue where enabling icon rating always showed five white stars. Retrieve the correct rating from KFileMetaData::UserMetaData for local files and insert it into the item data. This ensures both files and folders display the updated rating correctly.
BUG: 512940
|
|
(cherry picked from commit 74285708c697b7a05f22da3ce4d1032d6dfa539c)
|
|
|
|
There is one bool setting in Dolphin Interface->Folders&Tabs->Split_view
which determines which panel is closed on "Close split view" button
click (currently focused or unfocused one).
This commit replaces this setting with (enum-based) 3-state combo box.
Since now we can set "When closing a split view" action to:
- Close the active pane
- Close the inactive pane
- Close the right pane
BUG: 464696
BUG: 186185
|
|
Use loop index 'i' instead of function parameter 'index' for setTabToolTip.
Previously all tooltips would be set on the newly inserted tab instead of
their respective tabs.
|
|
Calling createRolePixmap() while roleIndex is < 0 (which is the case for
the header side padding) would cause access to a negative index of a
vector, so exit the function before so and do nothing.
BUG: 511057
|
|
This commit uses KUrlNavigator focus indicator to show sufficiently which panel (left or right) is currently active in split mode.
This MR is based on KIO changes in https://invent.kde.org/frameworks/kio/-/merge_requests/2054
See discussion in MR: !1076 (comment 1334290), see https://invent.kde.org/frameworks/kio/-/merge_requests/2058
@teams/vdg
{width=849 height=313}
{width=849 height=313}
{width=849 height=313}
{width=849 height=313}
@teams/vdg
BUG: 150718
BUG: 428440
|
|
If you are in ~
And create at once ~/1/2
Select the 1 folder afterwards
|
|
Use current view url as fallback.
Don't update the selection after a directory is created, except if there
was no selection.
CCBUG: 508196
BUG: 512020
|
|
Similarly to Microsoft explorer.
FEATURE: 512383
|
|
certain glyphs
In the Details view the name (text) column could appear vertically off-center for file names containing certain Unicode glyphs (for example "』"). The issue is caused by a mismatch between the generic font metrics ascent and the actual ascent of the rendered QTextLine for that glyph, which shifts the baseline and thus the visual vertical centering.
This change computes the QTextLine ascent for the (single) layouted line and adjusts the vertical position by the difference between the font metrics ascent and the line ascent. The adjustment is applied only for the name (text) role so other columns are unaffected.
BUG: 512152
|
|
media file is selected
To reproduce the crash:
- Open Dolphin, disable information panel and close Dolphin
- Re-open Dolphin
- Select a video file
- Enable information panel
- Crash
Problem is that some elements of the MediaWidget panel are created when the widget is shown, in `showEvent` (`m_seekSlider` and `m_topLayout`), and these elements are called before being created.
This MR fixes 2 different crashes:
- Crash creating panel when a video file is selected (call to `m_seekSlider` before its creation)
- Crash creating panel when a video file is selected and autoplay enabled (call to `m_topLayout` before its creation)
|
|
"Sort By field" could be understood as an extra field that contains a "Sort By" value
|
|
Checks if the second action in the submenu is actually an app and not a
separator, and add hint "Shift + Middle Click".
|
|
When Dolphin config was set to start in split mode by default
AND simply open the given folder in both panels
(Settings -> Folders&Tabs -> Show on startup -> selected folder [NOT "...state from last time"])
no view was initially active making weird side-effects described in both bugs.
This commit solves that by calling mainWindow->openDirectories
on start when both of the above conditions are met.
BUG: 503576
BUG: 508554
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
This reverts commit 122fee5625f0285ec4ebda79162c72390989eb2a.
This behavior change was well-intentioned, but has significant usability
and speed drawbacks that have not been addressed:
- Keyboard-driven folder manipulation became slower
- Unexpected behavioral differences when opening files with the pointer
compared to when opening them with the keyboard introduced
inconsistency and cognitive load
- Unexpected opening of selection mode during fast operation introduced
the potential for confusion and additional errors
- Dolphin's behavior became inconsistent with that of other file
managers users may be accustomed to
The bug tracker, discuss.kde.org, and Reddit are full of complaints
about this change. It's been a year now; I think it's clear that many
Dolphin users have not gotten used to and accepted it. I have to count
myself as one of them, I'm afraid. I've tried to get used to it for a
year, but I just have not been able to.
I don't believe the benefits of this change outweigh the drawbacks, so
let's revert it.
24d859cf19e90fa22ed687b36a68231625c1bd80 was explicitly mentioned as a
thing that should also be reverted in this case, but it's already been
done.
BUG: 494125
BUG: 511966
CCBUG: 424723
CCBUG: 492404
FIXED-IN: 25.12.0
|
