1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
|
/***************************************************************************
* Copyright (C) 2010 by Frank Reininghaus ([email protected]) *
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
* *
* This program is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License *
* along with this program; if not, write to the *
* Free Software Foundation, Inc., *
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
***************************************************************************/
#include <qtest_kde.h>
#include "testhelper.h"
#include "views/dolphindetailsview.h"
#include "views/dolphinview.h"
#include "views/dolphinmodel.h"
#include "views/dolphindirlister.h"
#include "views/dolphinsortfilterproxymodel.h"
#include "views/zoomlevelinfo.h"
#include <KTempDir>
#include <QtCore/QDir>
#include "kdebug.h"
class DolphinDetailsViewTest : public QObject
{
Q_OBJECT
private slots:
void initTestCase();
void cleanupTestCase();
void bug234600_overlappingIconsWhenZooming();
private:
TestHelper* m_helper;
DolphinView* m_view;
};
void DolphinDetailsViewTest::initTestCase()
{
// add time stamps to find origin of test failures due to timeout at
// http://my.cdash.org/index.php?project=kdebase&date=
qputenv("KDE_DEBUG_TIMESTAMP", QByteArray("1"));
m_helper = new TestHelper;
m_view = m_helper->view();
}
void DolphinDetailsViewTest::cleanupTestCase()
{
delete m_helper;
}
/**
* When the icon size is changed, we have to make sure that the maximumSize given
* to KFileItemDelegate for rendering each item is updated correctly. If this is not
* done, the visualRects are clipped by the incorrect maximum size, and the icons
* may overlap, see
*
* https://bugs.kde.org/show_bug.cgi?id=234600
*/
void DolphinDetailsViewTest::bug234600_overlappingIconsWhenZooming()
{
QStringList files;
files << "a" << "b" << "c" << "d";
m_helper->createFiles(files);
m_view->setMode(DolphinView::DetailsView);
DolphinDetailsView* detailsView = qobject_cast<DolphinDetailsView*>(m_helper->itemView());
QVERIFY(detailsView);
m_view->resize(400, 400);
m_view->show();
QTest::qWaitForWindowShown(m_view);
// We have to make sure that the view has loaded the directory before we start the test.
// TODO: This will be needed frequently. Maybe move to TestHelper.
kDebug() << "Reloading view and waiting for the finishedPathLoading(const KUrl&) signal...";
QSignalSpy finished(m_view, SIGNAL(finishedPathLoading(const KUrl&)));
m_view->reload();
while (finished.count() != 1) {
QTest::qWait(50);
}
kDebug() << "...signal received, continuing";
QModelIndex index0 = detailsView->model()->index(0, 0);
detailsView->setCurrentIndex(index0);
QCOMPARE(detailsView->currentIndex(), index0);
// Setting the zoom level to the minimum value and triggering DolphinDetailsView::currentChanged(...)
// should make sure that the bug is triggered.
int zoomLevel = ZoomLevelInfo::minimumLevel();
m_view->setZoomLevel(zoomLevel);
QModelIndex index1 = detailsView->model()->index(1, 0);
detailsView->setCurrentIndex(index1);
QCOMPARE(detailsView->currentIndex(), index1);
kDebug() << "Now checking zoom levels...";
// Increase the zoom level successively to the maximum.
while(zoomLevel < ZoomLevelInfo::maximumLevel()) {
zoomLevel++;
kDebug() << "Testing zoom level" << zoomLevel;
m_view->setZoomLevel(zoomLevel);
//Check for each zoom level that the height of each item is at least the icon size.
QVERIFY(detailsView->visualRect(index1).height() >= ZoomLevelInfo::iconSizeForZoomLevel(zoomLevel));
}
m_view->hide();
kDebug() << "Cleaning up test directory...";
m_helper->cleanupTestDir();
kDebug() << "Done.";
}
QTEST_KDEMAIN(DolphinDetailsViewTest, GUI)
#include "dolphindetailsviewtest.moc"
|
