diff options
| author | Nathaniel Graham <[email protected]> | 2018-04-02 16:52:08 -0600 |
|---|---|---|
| committer | Nathaniel Graham <[email protected]> | 2018-04-03 16:39:32 -0600 |
| commit | 993c47f30923e39b33dbd47a2a62e3dde5ccdbe4 (patch) | |
| tree | 723e503e97c51eac55f78bb47b641beb4f265db9 /src/panels/information/informationpanelcontent.h | |
| parent | eab70b2ac4a8be16a05a015f973527686ed65ae7 (diff) | |
Show folder previews for items that have a Places Panel entry
Summary:
informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug.
BUG: 392621
FIXED-IN: 18.08.0
Test Plan:
Before:
{F5782793}
After:
{F5782794}
Detailed test procedure:
- Open the Information Panel
- Turn on previews
- Put some pictures in ~/Pictures
- Hover over it and see that the Information Panel shows a preview of its contents
- Add ~/Pictures to the Places panel
- Hover over it again and see that previews are no longer displayed
- Apply the patch and restart Dolphin
- Hover over it once more and see that there are now previews, yay!
Reviewers: #dolphin, markg, elvisangelaccio
Reviewed By: markg, elvisangelaccio
Subscribers: markg, broulik
Differential Revision: https://phabricator.kde.org/D11894
Diffstat (limited to 'src/panels/information/informationpanelcontent.h')
| -rw-r--r-- | src/panels/information/informationpanelcontent.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/panels/information/informationpanelcontent.h b/src/panels/information/informationpanelcontent.h index 80f3c8e22..9223fcc5a 100644 --- a/src/panels/information/informationpanelcontent.h +++ b/src/panels/information/informationpanelcontent.h @@ -116,14 +116,6 @@ private slots: private: /** - * Checks whether the an URL is repesented by a place. If yes, - * then the place icon and name are shown instead of a preview. - * @return True, if the URL represents exactly a place. - * @param url The url to check. - */ - bool applyPlace(const QUrl& url); - - /** * Sets the text for the label \a m_nameLabel and assures that the * text is split in a way that it can be wrapped within the * label width (QLabel::setWordWrap() does not work if the |
