terminalpanel: delete konsolePart in destructor, use unique_ptr for KXMLGUIBuilder

Deleting konsolePart before QObject child cleanup ensures
m_konsolePartClientBuilder is still alive when the lambda connected
to m_terminalWidget::destroyed fires and calls factory->removeClient().

1 files changed, 4 insertions, 0 deletions

diff --git a/src/panels/terminal/terminalpanel.h b/src/panels/terminal/terminalpanel.h
index 7f4e9e36c..d6ed4b981 100644
--- a/src/panels/terminal/terminalpanel.h
+++ b/src/panels/terminal/terminalpanel.h
@@ -12,6 +12,9 @@
 
 #include <QQueue>
 
+#include <memory>
+
+class KXMLGUIBuilder;
 class TerminalInterface;
 class KActionCollection;
 class KMessageWidget;
@@ -94,6 +97,7 @@ private:
     QWidget *m_terminalWidget;
     KMessageWidget *m_konsolePartMissingMessage;
     KParts::ReadOnlyPart *m_konsolePart;
+    std::unique_ptr<KXMLGUIBuilder> m_konsolePartClientBuilder;
     QString m_konsolePartCurrentDirectory;
     QQueue<QString> m_sendCdToTerminalHistory;
     org::kde::KIOFuse::VFS m_kiofuseInterface;