┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/information/informationpanelcontent.h
AgeCommit message (Collapse)Author
2019-04-23[InformationPanel] Use the new inline configuration modeStefan Brüns
Summary: The current external configuration dialog has some issues: - its layout is suboptimal, as its initial size is typically to small - it is quite disassociated with the actual widget it configures, properties have a different order, and the property names can be quite abstract without the corresponding value. Doing the visibility selection inline typically avoids the sizing problem, as the containing application (dolphin) is often vertically maximized. The selection becomes more obvious, as the item order is kept, and the values are shown. Depends on D20524 CCBUG: 389571 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20525
2019-04-14Remove last traces of KFileMetaDataWidget from information panelStefan Brüns
Summary: The whole information panel is not included when Baloo is not found, so there is no need for the HAVE_BALOO guards. KFileMetaDataWidget and KFileMetaDataConfigurationWidget were never part of KF5, see https://git.reviewboard.kde.org/r/113153/ Test Plan: ctest Reviewers: #frameworks, apol, ngraham, #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20513
2019-03-24[InformationPanel] Hide the video when the preview is disabled, avoid ↵Méven Car
computing the preview when it is disabled Summary: Bug symptom : {F6698879} Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled. Test Plan: # In dolphin with an information panel with preview on # launch the video preview # Disable the preview ->bug 1: the video player control is still visible (this bug fix this) # re-enable preview -> bug 2: the video stays visible and the preview is displayed above (this bug fix this) Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19844
2019-03-17Fix a todo: InformationPanelContent::configureSettings code is moved to ↵Méven Car
InformationPanel::contextMenuEvent Summary: Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent Adding necessary accessors and changing visibility of one slot. Test Plan: 1 compile 2 in dolphin right on the information panel 3 toggle preview 4 from the same context menu, click configure, metadadata settings appears 5 toggle "condensed date" if available Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19832
2019-03-12Correctly position context menu of the information panel under wayland with ↵Méven Car
a secondary screen Summary: According to my testing this bug occurs because Qcursor::pos() does not work as expected under wayland on a secondary screen, then it returns inaccurate data. This could hide bugs elsewhere. BUG: 404799 FIXED-IN: 19.04.0 Test Plan: Under Wayland test the context menu on both screens. Do the same under Xorg. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, nicolasfella, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19535
2018-04-03Show folder previews for items that have a Places Panel entryNathaniel Graham
Summary: informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug. BUG: 392621 FIXED-IN: 18.08.0 Test Plan: Before: {F5782793} After: {F5782794} Detailed test procedure: - Open the Information Panel - Turn on previews - Put some pictures in ~/Pictures - Hover over it and see that the Information Panel shows a preview of its contents - Add ~/Pictures to the Places panel - Hover over it again and see that previews are no longer displayed - Apply the patch and restart Dolphin - Hover over it once more and see that there are now previews, yay! Reviewers: #dolphin, markg, elvisangelaccio Reviewed By: markg, elvisangelaccio Subscribers: markg, broulik Differential Revision: https://phabricator.kde.org/D11894
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-02-04Fix all krazy #include warningsElvis Angelaccio
- "include own header first line" - "put config.h in angle brackets line" - "do not include QtModule/QtClass line" `QElapsedTimer` was implicitly included by kfileitemmodelsortalgorithm.h, now we need to explicitly include it in kfileitemmodel.cpp. We also need to explicitly link to `Qt5::Concurrent`, otherwise we cannot `#include <QtConcurrentRun>`.
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2014-11-03Q_DECL_OVERRIDELukáš Tinkl
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-02-06Port Dolphin to BalooVishesh Handa
Nepomuk is being replaced with Baloo
2014-01-06Kill any running preview jobs before starting a new oneFrank Reininghaus
If loading a preview takes long, it was possible before this commit that a preview for a new item was requested before the first preview was shown. In that case, there was a race condition, and the first preview to arrive stayed in the Information Panel. This commit fixes this by keeping a pointer to the preview job and killing it before starting a new one. BUG: 250787 FIXED-IN: 4.12.1 REVIEW: 114561
2013-01-07Dolphin: Make Nepomuk Support OptionalVishesh Handa
Use the KFileMetadataWidget if Nepomuk is not present. REVIEW: 108236
2013-01-02Dolphin Information Panel: Use Nepomuk2::FileMetadataWidgetVishesh Handa
Instead of the KFileMetadataWidget. The Nepomuk widget is just a copy of the KFileMetadataWidget which utilizes Nepomuk2.
2012-06-02Use PlacesItemModel instead of KFilePlacesModelPeter Penz
This allows inserting items to the corresponding group.
2012-05-29Get rid of obsolete DolphinPlacesModelPeter Penz
2012-05-19Show video previews according to file content instead of the mimetype-stringPeter Penz
Show a video widget depending on the video content instead of the mimetype string: There are container formats which can be either audios or videos. Besides, the rmvb video files have a mimetype of "application/vnd.rn-realmedia", and these files can be recognized as videos correctly now. The patch has been provided by Hui Ni. REVIEW: 104988 FIXED-IN: 4.9
2011-02-19Use the new KIO::PreviewJob APIPeter Penz
This makes it unnecessary to manually apply the plugins. See https://git.reviewboard.kde.org/r/100578/ for more details.
2011-02-04Update e-mail address from [email protected] to [email protected]Peter Penz
2011-02-04Use capitalized KDE includesPeter Penz
2011-01-18Assure that the enabled plugins for previews are set for the Information ↵Peter Penz
Panel and the tooltips. This fixes the issue that a disabled thumbnail-plugin might be chosen. For 4.7 it should be considered to move this code into KIO::filePreview() as default already (will provide a patch on the reviewboard). svn path=/trunk/KDE/kdebase/apps/; revision=1215459
2010-12-31Lock panels per default and allow to unlock them like in Amarok.Peter Penz
BUG: 229811 FIXED-IN: 4.7.0 svn path=/trunk/KDE/kdebase/apps/; revision=1210424
2010-10-07Internal cleanup for panels: Let the panel-implementations decide whether ↵Peter Penz
they accept an URL or not. svn path=/trunk/KDE/kdebase/apps/; revision=1183480
2010-08-07Fix spelling errors reported by crazyPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=1160316
2010-07-10Fix forward declationLaurent Montel
svn path=/trunk/KDE/kdebase/apps/; revision=1148408
2010-03-25Open the meta data configuration dialog modelessPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=1107448
2010-03-22Use KFileMetaDataWidget from kdelibs. Still open: Provide dialog which wraps ↵Peter Penz
KFileMetaDataConfigurationWidget. svn path=/trunk/KDE/kdebase/apps/; revision=1106465
2010-01-15assure that the widgets of the panels are resized after receiving the Polish ↵Peter Penz
event svn path=/trunk/KDE/kdebase/apps/; revision=1075076
2009-11-25* Fixed execution of links in the metadata widget.Sebastian Trueg
* Do not try to list non-listable URLs. svn path=/trunk/KDE/kdebase/apps/; revision=1054300
2009-11-06move the position of the filename below the previewPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=1045798
2009-10-28After some discussions at http://reviewboard.kde.org/r/1938 it turned out ↵Peter Penz
that moving KMetaDataWidget and KMetaDataConfigurationDialog to kdelibs should be postponed to KDE 4.5. The main reason is that adding application specific properties is not possible with the current API in a generic way. Also the topic how to hide properties application specific is an open point... So now all adjustments from the review have been adapted to the Dolphin code. After KDE 4.4 has been released some refactoring will be done so that the open topics above are handled in a nice way. svn path=/trunk/KDE/kdebase/apps/; revision=1041547
2009-10-19Fix some spelling mistakes in comments.Raphael Kubo da Costa
svn path=/trunk/KDE/kdebase/apps/; revision=1037779
2009-10-10Reactivate showing of general meta information. This is also done as part of ↵Peter Penz
the LoadFilesThread and is no special case anymore like in the old code base. svn path=/trunk/KDE/kdebase/apps/; revision=1033722
2009-10-10Start of refactoring so that the metadata widget can be moved outside of ↵Peter Penz
Dolphin for other applications. The temporary removed code will be integrated again within the next 10 days (-> currently no meta data is shown and cannot be updated). svn path=/trunk/KDE/kdebase/apps/; revision=1033585
2009-07-08Fixed regression when refactoring the Information Panel: Don't forget to ↵Peter Penz
give a visual indication if the generation of the preview takes long. svn path=/trunk/KDE/kdebase/apps/; revision=993584
2009-07-05The complexity of the class InformationPanel has grown a lot from KDE 4.0 to ↵Peter Penz
KDE 4.3. One main reason is that a lot of things are done now asynchronously with timers to prevent a blocking UI and unnecessary expensive operations. To keep the Information Panel maintainable and prepared for future features a cleanup has been done. The whole user interface handling has been moved into the class InformationPanelContent that offers a straight forward interface: showItem(const KFileItem& item) and showItems(const KFileItemList& items). The class InformationPanel is responsible for calling those methods in a way that hovering items, changing directories, doing selections, rename and delete operations, ... don't result in calling showItem() 10 times per second. This cleanup won't be backported to KDE 4.3.x svn path=/trunk/KDE/kdebase/apps/; revision=991902
generated by cgit v1.3 (git 2.53.0) at 2026-04-29 06:49:34 +0000